Skip to content

nettle: 3.4 -> 3.4.1 (security) #51688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2018
Merged

nettle: 3.4 -> 3.4.1 (security) #51688

merged 1 commit into from
Dec 8, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

https://lists.gnu.org/archive/html/info-gnu/2018-12/msg00001.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Dec 8, 2018
@vcunat vcunat added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Dec 8, 2018
@vcunat vcunat self-assigned this Dec 8, 2018
vcunat
vcunat approved these changes Dec 8, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS sound safe. I built several packages.

@vcunat vcunat merged commit ff084c7 into NixOS:staging Dec 8, 2018
vcunat added a commit that referenced this pull request Dec 8, 2018
@vcunat
Merge #51688: nettle: 3.4 -> 3.4.1 (security)
b9d22d3
vcunat added a commit that referenced this pull request Dec 8, 2018
@vcunat
Merge #51688: nettle: 3.4 -> 3.4.1 (security)
2e76995 
(cherry picked from commit b9d22d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtzWill @vcunat @GrahamcOfBorg