Skip to content

purple-hangouts: 2018-03-28 -> 2018-12-02 #51704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2018
Merged

purple-hangouts: 2018-03-28 -> 2018-12-02 #51704

merged 1 commit into from
Dec 29, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

Motivation for this change

Wanted to try it and thought I'd get various fixes and such :).

https://bitbucket.org/EionRobb/purple-hangouts/commits/all

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 8, 2018
@dtzWill dtzWill force-pushed the update/purple-hangouts-2018 branch from 9ede6b1 to 98abe87 Compare December 29, 2018 20:08
@dtzWill
Copy link
Member Author

dtzWill commented Dec 29, 2018

(autosquash'd the fixup, ty, been using for a while and works for me! :))

@dtzWill dtzWill merged commit 3a0b75f into NixOS:master Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzWill @GrahamcOfBorg