Skip to content

vivid: init at 0.4.0 #51709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2018
Merged

vivid: init at 0.4.0 #51709

merged 1 commit into from
Dec 18, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

Motivation for this change

Interesting, limited in themes it ships with
but configurable and hopefully more to come.

Found poking at 'exa' :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 8, 2018
@srhb
Copy link
Contributor

srhb commented Dec 12, 2018 

[...]
 Downloading libc v0.2.44
   Vendoring ansi_colours v1.0.1 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/ansi_colours-1.0.1) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/ansi_colours
   Vendoring ansi_term v0.11.0 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/ansi_term-0.11.0) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/ansi_term
   Vendoring atty v0.2.11 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/atty-0.2.11) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/atty
   Vendoring bitflags v1.0.4 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/bitflags-1.0.4) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/bitflags
   Vendoring cc v1.0.25 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/cc-1.0.25) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/cc
   Vendoring clap v2.32.0 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/clap-2.32.0) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/clap
   Vendoring kernel32-sys v0.2.2 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/kernel32-sys-0.2.2) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/kernel32-sys
   Vendoring lazy_static v1.2.0 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/lazy_static-1.2.0) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/lazy_static
   Vendoring libc v0.2.44 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/libc-0.2.44) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/libc
   Vendoring linked-hash-map v0.5.1 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/linked-hash-map-0.5.1) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/linked-hash-map
   Vendoring redox_syscall v0.1.43 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/redox_syscall-0.1.43) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/redox_syscall
   Vendoring redox_termios v0.1.1 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/redox_termios-0.1.1) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/redox_termios
   Vendoring strsim v0.7.0 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/strsim-0.7.0) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/strsim
   Vendoring term_size v0.3.1 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/term_size-0.3.1) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/term_size
   Vendoring termion v1.5.1 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/termion-1.5.1) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/termion
   Vendoring textwrap v0.10.0 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/textwrap-0.10.0) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/textwrap
   Vendoring unicode-width v0.1.5 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/unicode-width-0.1.5) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/unicode-width
   Vendoring vec_map v0.8.1 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/vec_map-0.8.1) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/vec_map
   Vendoring winapi v0.2.8 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/winapi-0.2.8) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/winapi-0.2.8
   Vendoring winapi v0.3.6 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/winapi-0.3.6) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/winapi
   Vendoring winapi-build v0.1.1 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/winapi-build-0.1.1) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/winapi-build
   Vendoring winapi-i686-pc-windows-gnu v0.4.0 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/winapi-i686-pc-windows-gnu-0.4.0) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/winapi-i686-pc-windows-gnu
   Vendoring winapi-x86_64-pc-windows-gnu v0.4.0 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/winapi-x86_64-pc-windows-gnu-0.4.0) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/winapi-x86_64-pc-windows-gnu
   Vendoring yaml-rust v0.4.2 (/build/source/cargo-home.upT/registry/src/github.com-1ecc6299db9ec823/yaml-rust-0.4.2) to /nix/store/58wvzz5xxy7vv390cibymx8z3lwz72h3-vivid-0.4.0-vendor/yaml-rust
To use vendored sources, add this to your .cargo/config for this project:

builder for '/nix/store/kn8q6df9slz55w6br63msw5h8biksqih-vivid-0.4.0-vendor.drv' failed with exit code 1
cannot build derivation '/nix/store/q82c1d65jn7kdv7cdalv2ahq7hmsa636-vivid-0.4.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/q82c1d65jn7kdv7cdalv2ahq7hmsa636-vivid-0.4.0.drv' failed

eep!

@dtzWill
Copy link
Member Author

dtzWill commented Dec 15, 2018 •
edited
Loading

Ruhroh! Will investigate and fix shortly, assuming it's the expected hash fixup :).

EDIT: double ruh-roh, not hash fixup but something else? boo. Investigating...

@dtzWill dtzWill force-pushed the feature/vivid-0.4.0 branch from dd1a4ec to 890afbc Compare December 15, 2018 23:39
@dtzWill
Copy link
Member Author

dtzWill commented Dec 15, 2018

Unrelated bug in rust infra I think, rebasing seems to fix the problem 😇.

Mic92
Mic92 reviewed Dec 16, 2018
View reviewed changes
@dtzWill dtzWill force-pushed the feature/vivid-0.4.0 branch from 890afbc to c2cde10 Compare December 18, 2018 15:39
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 18, 2018
@Mic92 Mic92 merged commit a647ab1 into NixOS:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtzWill @srhb @Mic92 @GrahamcOfBorg