Skip to content

remind: 3.1.15 -> 3.1.16, new home, cleanup #51717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2018
Merged

remind: 3.1.15 -> 3.1.16, new home, cleanup #51717

merged 1 commit into from
Dec 16, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 8, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 8, 2018
@7c6f434c
Copy link
Member

7c6f434c commented Dec 8, 2018

Old upstream homepage checked: mentions the new one as the current one. Should this be mentioned in the commit message maybe?

@dtzWill
remind: 3.1.15 -> 3.1.16, new home, cleanup
dc6ffc4 
Old page links to new home :).
@dtzWill dtzWill force-pushed the update/remind-3.1.16 branch from e03b85c to dc6ffc4 Compare December 15, 2018 23:44
@dtzWill dtzWill merged commit a4b4fa5 into NixOS:master Dec 16, 2018
@dtzWill dtzWill deleted the update/remind-3.1.16 branch December 16, 2018 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtzWill @7c6f434c @GrahamcOfBorg