Skip to content

postgresql: Build with icu support #51719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2018
Merged

postgresql: Build with icu support #51719

merged 1 commit into from
Dec 9, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 8, 2018

Motivation for this change

Compile PostgreSQL with ICU collation support
https://wiki.postgresql.org/wiki/New_in_postgres_10#ICU_Collation_Support

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from thoughtpolice as a code owner December 8, 2018 05:48
srl295
srl295 approved these changes Dec 8, 2018
View reviewed changes
Copy link

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and +1 for using pkgconfig instead of icu-config

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 8, 2018
@rasendubi
Copy link
Member

@GrahamcOfBorg build postgresql_10 postgresql_11

@rasendubi rasendubi merged commit ef966c1 into NixOS:master Dec 9, 2018
@marsam marsam deleted the postgresql-build-icu-support branch December 10, 2018 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marsam @rasendubi @srl295 @GrahamcOfBorg