Skip to content

gawkextlib: init at unstable #51721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Dec 8, 2019
Merged

gawkextlib: init at unstable #51721

merged 21 commits into from
Dec 8, 2019

Conversation

tomberek
Copy link
Contributor

@tomberek tomberek commented Dec 8, 2018 •
edited
Loading

Motivation for this change

Using AWK recently. Found some extensions that are useful for JSON, etc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 8, 2018
@tomberek tomberek force-pushed the gawkextlib-init branch 2 times, most recently from a29f4b1 to 9b83ad5 Compare December 11, 2018 06:30
veprbl
veprbl reviewed Dec 26, 2018
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some parts could use some rework.

@tomberek
Copy link
Contributor Author

@veprbl Thanks for the review. Updated PR taking your suggestions. There are a few I don't have a solid answer for at the moment.

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

Are there any updates on this pull request, please?

@tomberek
Copy link
Contributor Author

Not right now. I’m willing to make some changes if there is interest.

@tomberek
Copy link
Contributor Author

tomberek commented Dec 1, 2019

Woops. Did a massive merge by mistake. Force-pushed a more reasonable change set.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Dec 1, 2019
@veprbl veprbl removed the request for review from thoughtpolice December 1, 2019 16:36
@veprbl veprbl self-assigned this Dec 2, 2019
@tomberek
Copy link
Contributor Author

tomberek commented Dec 7, 2019

Anything else needed?

@veprbl
Copy link
Member

veprbl commented Dec 7, 2019

@tomberek I made some changes, could you review?

@veprbl veprbl removed their assignment Dec 7, 2019
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 7, 2019
@tomberek
Copy link
Contributor Author

tomberek commented Dec 7, 2019

Builds and functions as expected

@veprbl
Copy link
Member

veprbl commented Dec 8, 2019

@GrahamcOfBorg build gawkextlib gawk-with-extensions

veprbl
veprbl approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gawkextlib.json appears to be working

@veprbl veprbl merged commit 774ad67 into NixOS:master Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomberek @mmahut @veprbl @GrahamcOfBorg