Skip to content

libsass: 3.5.4 -> 3.5.5 #51741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2018
Merged

libsass: 3.5.4 -> 3.5.5 #51741

merged 1 commit into from
Dec 8, 2018

Conversation

florianjacob
Copy link
Contributor

Motivation for this change

3.5.5 reverts the css import breaking behaviour from 3.5.3:
https://github.com/sass/libsass/releases

It also contains the included security patch, which could be therefore removed:
https://github.com/sass/libsass/commits/3.5.5

Not totally sure on backporting - this update breaks the current behaviour, but if you define the current behaviour as broken, for which there are reasons, it's more of an un-breaking than a breaking change.

Maintainers: @codyopel @offlinehacker

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@florianjacob
Copy link
Contributor Author

@GrahamcOfBorg build libsass

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 8, 2018
@Mic92 Mic92 merged commit 950d552 into NixOS:master Dec 8, 2018
@florianjacob florianjacob deleted the libsass branch December 8, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants