nixos/iotop: add module #51749
Merged
nixos/iotop: add module #51749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: nixos
fpletz
added
8.has: module (new)
The `iotop` program can't be started by an unprivileged user because of missing root privileges. The issue can be fixed by creating a setcap wrapper for `iotop` which contains `cap_net_admin`.
Ma27
force-pushed
the
add-iotop-module
branch
from
ff8fe5f to
7490e96
Compare
GrahamcOfBorg
added
the
8.has: module (update)
|
as this is a fairly trivial module, I'd do the merge tomorrow unless there are any folks against it. |
infinisil
reviewed
Feb 7, 2019
| programs.iotop.enable = mkEnableOption "iotop + setcap wrapper"; | ||
| }; | ||
| config = mkIf cfg.enable { | ||
| environment.systemPackages = [ pkgs.iotop ]; |
There was a problem hiding this comment.
/run/wrappers/bin is on $PATH already, so I don't think this is needed (or even does anything, as the iotop in $PATH will override this one)
There was a problem hiding this comment.
Oh, guess I was a couple minutes late :)
There was a problem hiding this comment.
good catch! Fixed in 6a0d2ff
Ma27
added a commit
to Ma27/nixpkgs
that referenced
this pull request
Feb 7, 2019
The binary will be in `/run/wrappers/bin` and adding `pkgs.iotop` won't have any effect. See also NixOS#51749 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The
iotopprogram can't be started by an unprivileged user because ofmissing root privileges. The issue can be fixed by creating a
setcap wrapper for
iotopwhich containscap_net_admin.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)