Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: add geographiclib and update geopy #51839

Closed
wants to merge 4 commits into from
Closed

Conversation

@MMesch
Copy link
Contributor

@MMesch MMesch commented Dec 10, 2018

Motivation for this change

my first nixpkgs PR. Let me know if something should be different.

(1) added geographiclib from pip.
(2) updated geopy from 1.11 -> 1.18
(3) enabled python3 support for geopy

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -11,7 +11,7 @@
buildPythonPackage rec {
pname = "geopy";
version = "1.18.0";
disabled = !isPy27;
disabled = false;

This comment has been minimized.

@prusnak

prusnak Dec 11, 2018
Member

Maybe just remove the line completely?

buildPythonPackage rec {
pname = "geographiclib";
version = "1.49";
disabled = false;

This comment has been minimized.

@dotlambda

dotlambda Dec 11, 2018
Member

Suggested change
disabled = false;
sha256 = "635da648fce80a57b81b28875d103dacf7deb12a3f5f7387ba7d39c51e096533";
};

doCheck = false; # too much

This comment has been minimized.

@dotlambda

dotlambda Dec 11, 2018
Member

Too much what? Please add a meaningful comment

This comment has been minimized.

@prusnak

prusnak Dec 11, 2018
Member

This was copy-pasted from geopy package. It probably shouldn't belong in this newly created file.

doCheck = false; # too much

meta = with stdenv.lib; {
homepage = "https://geographiclib.sourceforge.io";

This comment has been minimized.

@dotlambda

dotlambda Dec 11, 2018
Member

Suggested change
homepage = "https://geographiclib.sourceforge.io";
homepage = https://geographiclib.sourceforge.io;
Copy link
Member

@dotlambda dotlambda left a comment

The last two commits should be squashed together using the commit message pythonPackages.geopy: 1.11 -> 1.18

@knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Mar 18, 2019

@MMesch Are you still intersted in pushing this forward? Looks like we could use this for #56826.

@FRidh
Copy link
Member

@FRidh FRidh commented Feb 9, 2020

Nothing happening so closing.

@FRidh FRidh closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.