Skip to content

postgresql_9_3: drop #52052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

postgresql_9_3: drop #52052

wants to merge 1 commit into from

Conversation

lsix
Copy link
Member

@lsix lsix commented Dec 14, 2018

Motivation for this change

Postgresql 9.3 reached end of life on november 11, 2018 (see
https://www.postgresql.org/about/news/1905/)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lsix
postgresql_9_3: drop
2780924 
Postgresql 9.3 reached end of life on november 11, 2018 (see
https://www.postgresql.org/about/news/1905/)
@lsix lsix requested a review from thoughtpolice as a code owner December 14, 2018 14:08
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 14, 2018
@infinisil
Copy link
Member

Can you fix the conflict? This looks good to me

thoughtpolice
thoughtpolice approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this. Yes, this looks good to me too! I'll go ahead and rebase this myself.

@lsix lsix deleted the drop_postgresql_9_3 branch August 22, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsix @infinisil @thoughtpolice @GrahamcOfBorg