Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxkit: 2017-07-08 -> v0.6 #52059

Closed
wants to merge 1 commit into from
Closed

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Dec 14, 2018

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Bump to the most recent released version 馃懠

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

vdemeester added a commit to vdemeester/nur-packages that referenced this pull request Dec 17, 2018
2017-07-07 -> v0.6

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester force-pushed the vdemeester:bump-linuxkit branch to 9839222 Dec 19, 2018
@vdemeester
Copy link
Member Author

@vdemeester vdemeester commented Jan 21, 2019

ping @Mic92

pkgs/development/tools/misc/linuxkit/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/misc/linuxkit/default.nix Outdated Show resolved Hide resolved
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester force-pushed the vdemeester:bump-linuxkit branch from 9839222 to 4029ac9 Feb 25, 2019
@vdemeester
Copy link
Member Author

@vdemeester vdemeester commented Feb 25, 2019

@ryantm Updated (and fixed the version report). I kept the git commit hash for the version output though (maybe we don't really care but鈥)

@ryantm
Copy link
Member

@ryantm ryantm commented Mar 3, 2019

I think we should leave out the git commit because it will be more of a pain to update, and we might accidentally bump the version without updating that rev attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can鈥檛 perform that action at this time.