New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/davmail: init #52096

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@furrycatherder
Copy link
Contributor

furrycatherder commented Dec 14, 2018

Motivation for this change

PR adds NixOS options for davmail, an IMAP/SMTP gateway server for MS Exchange.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Show resolved Hide resolved nixos/modules/services/mail/davmail.nix Outdated
@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Jan 7, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/9

Show resolved Hide resolved nixos/modules/services/mail/davmail.nix
Type = "simple";
ExecStart = "${pkgs.davmail}/bin/davmail"
+ optionalString (cfg.configFile != null) " ${cfg.configFile}";
Restart = "on-failure";

This comment has been minimized.

@Infinisil

Infinisil Jan 8, 2019

Contributor

Without specifying a user, this service will run as root. Try using DynamicUser to prevent that (and possibly StateDirectory and similar).

This comment has been minimized.

@Infinisil

Infinisil Jan 8, 2019

Contributor

Or alternatively, creating a new user as many services do too (but if DynamicUser would work that would be awesome)

This comment has been minimized.

@furrycatherder

furrycatherder Jan 10, 2019

Contributor

I just pushed changes to address your other comments. I'll test out DynamicUser when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment