New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bluez full package #52168

Merged
merged 2 commits into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@cdepillabout
Copy link
Contributor

cdepillabout commented Dec 15, 2018

Motivation for this change

This PR adds the top-level bluezFull package. This bluezFull package enables all the plugins provided by the bluez package.

It would be nice to have this bluezFull package for people that want to just get a bluez with all the bells and whistles instead of having to enable them one-by-one and compile bluez themselves.

I think this will mainly be used by people who want to use the Wiimote and Playstation 3/4 controllers over bluetooth without having to enable the individual options on bluez.

I called this package bluezFull after the gitFull package, but I am open to suggestions as to what it should be called. Another candidate might be bluezWithPlugins.

Pinging @veprbl (because of #51895).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cdepillabout added some commits Dec 15, 2018

[bluezFull] add bluezFull package that enables all plugins
This PR adds the top-level `bluezFull` package.  This `bluezFull`
package enables all the plugins provided by the `bluez` package.

@Infinisil Infinisil merged commit 9673380 into NixOS:master Dec 17, 2018

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@cdepillabout cdepillabout deleted the cdepillabout:add-bluezFull-package branch Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment