Skip to content

fanficfare: 3.1.1 -> 3.6.0 #52320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/fanficfare/versions.

meta.description for fanficfare is: '"FanFicFare is a tool for making eBooks from fanfiction web sites"'.

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
  • built on NixOS
  • /nix/store/axviy4g6clylslxcqzqydvdhxqr861dh-fanficfare-3.2.0/bin/.fanficfare-wrapped passed the binary check.
  • /nix/store/axviy4g6clylslxcqzqydvdhxqr861dh-fanficfare-3.2.0/bin/fanficfare passed the binary check.
  • 2 of 2 passed binary check by having a zero exit code.
  • 2 of 2 passed binary check by having the new version present in output.
  • found 3.2.0 with grep in /nix/store/axviy4g6clylslxcqzqydvdhxqr861dh-fanficfare-3.2.0
  • directory tree listing: https://gist.github.com/bd74db71f4b275d1c7246ad279c43e4c
  • du listing: https://gist.github.com/2311f82a6b262ed07d353df3e6d864fc
Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
fanficfare

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/axviy4g6clylslxcqzqydvdhxqr861dh-fanficfare-3.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A fanficfare https://github.com/r-ryantm/nixpkgs/archive/a15a8401f7e91e6bde394ab934aa7fb984410112.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/axviy4g6clylslxcqzqydvdhxqr861dh-fanficfare-3.2.0
ls -la /nix/store/axviy4g6clylslxcqzqydvdhxqr861dh-fanficfare-3.2.0/bin

cc @lucas8 for testing.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 16, 2018
@jtojnar
Copy link
Member

jtojnar commented Dec 16, 2018

Python 3 is now supported, we should switch.

@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to py3

@jtojnar jtojnar self-assigned this Apr 6, 2019
@jtojnar
Copy link
Member

jtojnar commented Apr 6, 2019

Switching to Python 3 breaks tests, opened an issue upstream: JimmXinu/FanFicFare#391

@timokau timokau changed the title fanficfare: 3.1.1 -> 3.2.0 fanficfare: 3.1.1 -> 3.6.0 Apr 6, 2019
Switch to Python 3 and fetching from Pypi
@jtojnar jtojnar force-pushed the auto-update/fanficfare branch from 096ef55 to 621c4b8 Compare April 6, 2019 22:33
@jtojnar
Copy link
Member

jtojnar commented Apr 6, 2019

According to upstream, there are no tests. No idea why does python3 ./setup.py test pick them up.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird. Anyhow, lgtm now.

@timokau
Copy link
Member

timokau commented Apr 7, 2019

@GrahamcOfBorg build fanficfare

@xeji xeji merged commit ca33a4f into NixOS:master Apr 9, 2019
@r-ryantm r-ryantm deleted the auto-update/fanficfare branch April 14, 2019 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants