Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosvm: init at 77.0.3865.105 #52352

Open
wants to merge 2 commits into
base: master
from

Conversation

@hyperfekt
Copy link
Contributor

hyperfekt commented Dec 16, 2018

Motivation for this change

crosvm is a virtual machine monitor for KVM, taking a role similar to qemu, but aiming to be much more secure by virtue of omitting the emulation of devices and using a memory-safe programming language as well as isolation of different components via seccomp. It is mostly used on Chromium OS, but not limited to it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Dec 19, 2018

Builds and was able to start running my current kernel (needed to extract vmlinux, even though it says wants bzImage?) which didn't get too far since no devices or disk :D.

@dtzWill

This comment has been minimized.

Copy link
Contributor

dtzWill commented Feb 27, 2019

R73:
dtzWill@5781a82

Although didn't test it beyond building and ensuring the crosvm tool runs.

Is this PR blocking on something? Any reservations about merging?

@hyperfekt

This comment has been minimized.

Copy link
Contributor Author

hyperfekt commented Feb 28, 2019

I haven't actually tested it any further than you in December because I got distracted before I could build one with the paravirtualized disk drivers, but in theory (we all know how that goes!) it should work.

@hyperfekt hyperfekt force-pushed the hyperfekt:init_crosvm branch from c207fef to 50edbaf May 15, 2019
@hyperfekt hyperfekt changed the title crosvm: init at R72-11316 crosvm: init at 75 May 15, 2019
@hyperfekt hyperfekt force-pushed the hyperfekt:init_crosvm branch from 50edbaf to 868cfef May 15, 2019
@hyperfekt

This comment has been minimized.

Copy link
Contributor Author

hyperfekt commented May 15, 2019

Updated to version 75. It's now a bit more complex since it has a dependency on a library somewhere else in the Chromium repo and we don't want to check the whole thing out.

@hyperfekt hyperfekt force-pushed the hyperfekt:init_crosvm branch from 868cfef to f911b4c May 16, 2019
@hyperfekt

This comment has been minimized.

Copy link
Contributor Author

hyperfekt commented May 16, 2019

Before this is merged, I would like for the branch this is based on to turn stable and I would like to figure out how Chromium OS release candidates (tracked here) are turned into actual Chromium OS releases so I can match them.

@aanderse

This comment has been minimized.

Copy link
Contributor

aanderse commented Aug 4, 2019

ping (triage)

@hyperfekt hyperfekt force-pushed the hyperfekt:init_crosvm branch from f911b4c to b9b917f Oct 27, 2019
@hyperfekt hyperfekt changed the title crosvm: init at 75 crosvm: init at 77.0.3865.105 Oct 27, 2019
@hyperfekt

This comment has been minimized.

Copy link
Contributor Author

hyperfekt commented Oct 27, 2019

This needs an updater script, some tests, and possibly some optional dependencies added.

EDIT: Update script provided by @alyssais! :D

@hyperfekt hyperfekt force-pushed the hyperfekt:init_crosvm branch 3 times, most recently from cfb33af to 4fa1995 Oct 27, 2019
@alyssais

This comment has been minimized.

Copy link
Member

alyssais commented Oct 29, 2019

@hyperfekt

This comment has been minimized.

Copy link
Contributor Author

hyperfekt commented Oct 29, 2019

@alyssais: That was just a function of crosvm requiring KVM (that's the linux part) and it shipping with seccomp policies for these two architectures.

@hyperfekt hyperfekt force-pushed the hyperfekt:init_crosvm branch from 4fa1995 to a4e2b02 Nov 2, 2019
@hyperfekt hyperfekt force-pushed the hyperfekt:init_crosvm branch from a4e2b02 to 0b89bd3 Nov 6, 2019
alyssais and others added 2 commits Dec 14, 2018
Co-Authored-By: hyperfekt <git@hyperfekt.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.