Skip to content

crosvm: init at 77.0.3865.105#52352

Merged
7c6f434c merged 2 commits into
masterfrom
unknown repository
Dec 17, 2019
Merged

crosvm: init at 77.0.3865.105#52352
7c6f434c merged 2 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 16, 2018

Motivation for this change

crosvm is a virtual machine monitor for KVM, taking a role similar to qemu, but aiming to be much more secure by virtue of omitting the emulation of devices and using a memory-safe programming language as well as isolation of different components via seccomp. It is mostly used on Chromium OS, but not limited to it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Dec 16, 2018
@dtzWill
Copy link
Copy Markdown
Member

dtzWill commented Dec 19, 2018

Builds and was able to start running my current kernel (needed to extract vmlinux, even though it says wants bzImage?) which didn't get too far since no devices or disk :D.

@dtzWill
Copy link
Copy Markdown
Member

dtzWill commented Feb 27, 2019

R73:
dtzWill@5781a82

Although didn't test it beyond building and ensuring the crosvm tool runs.

Is this PR blocking on something? Any reservations about merging?

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 28, 2019

I haven't actually tested it any further than you in December because I got distracted before I could build one with the paravirtualized disk drivers, but in theory (we all know how that goes!) it should work.

@ghost ghost changed the title crosvm: init at R72-11316 crosvm: init at 75 May 15, 2019
@ghost
Copy link
Copy Markdown
Author

ghost commented May 15, 2019

Updated to version 75. It's now a bit more complex since it has a dependency on a library somewhere else in the Chromium repo and we don't want to check the whole thing out.

Comment thread pkgs/applications/virtualization/crosvm/default.nix Outdated
Comment thread pkgs/applications/virtualization/crosvm/default.nix Outdated
@ghost
Copy link
Copy Markdown
Author

ghost commented May 16, 2019

Before this is merged, I would like for the branch this is based on to turn stable and I would like to figure out how Chromium OS release candidates (tracked here) are turned into actual Chromium OS releases so I can match them.

@aanderse
Copy link
Copy Markdown
Member

aanderse commented Aug 4, 2019

ping (triage)

@ghost ghost changed the title crosvm: init at 75 crosvm: init at 77.0.3865.105 Oct 27, 2019
@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 27, 2019

This needs an updater script, some tests, and possibly some optional dependencies added.

EDIT: Update script provided by @alyssais! :D

@alyssais
Copy link
Copy Markdown
Member

alyssais commented Oct 29, 2019 via email

@ghost
Copy link
Copy Markdown
Author

ghost commented Oct 29, 2019

@alyssais: That was just a function of crosvm requiring KVM (that's the linux part) and it shipping with seccomp policies for these two architectures.

Comment thread pkgs/applications/virtualization/crosvm/default-seccomp-policy-dir.patch Outdated
@ghost ghost requested review from FRidh and jonringer as code owners November 6, 2019 18:32
@ofborg ofborg Bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vim Advanced text editor 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 6, 2019
@ofborg ofborg Bot removed 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vim Advanced text editor 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 6, 2019
@7c6f434c
Copy link
Copy Markdown
Member

@hyperfekt the current version is ready for merge, right?

@alyssais is the CrosVM version you test in your SpectrumOS efforts the same as this PR?

@alyssais
Copy link
Copy Markdown
Member

alyssais commented Dec 16, 2019 via email

@7c6f434c 7c6f434c merged commit e726201 into NixOS:master Dec 17, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 17, 2019
crosvm: init at 77.0.3865.105
(cherry picked from commit e726201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants