freetype: 2.9 -> 2.9.1

[stephengroat]

exclude freetype-config

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[stephengroat]

tried running compilation of all dependent packages but got a python error

# nix-shell -p nox --run "nox-review wip"
Traceback (most recent call last):
  File "/nix/store/q44d9mm88q6b5xlxdf49maxapm00f82a-nox-0.0.6/bin/.nox-review-wrapped", line 12, in <module>
    sys.exit(cli())
  File "/nix/store/sbgdkzwznx5vx2w8iz1rxbxi6c3ibka6-python3.6-click-6.7/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/nix/store/sbgdkzwznx5vx2w8iz1rxbxi6c3ibka6-python3.6-click-6.7/lib/python3.6/site-packages/click/core.py", line 676, in main
    _verify_python3_env()
  File "/nix/store/sbgdkzwznx5vx2w8iz1rxbxi6c3ibka6-python3.6-click-6.7/lib/python3.6/site-packages/click/_unicodefun.py", line 118, in _verify_python3_env
    'for mitigation steps.' + extra)
RuntimeError: Click will abort further execution because Python 3 was configured to use ASCII as encoding for the environment.  Consult http://click.pocoo.org/python3/for mitigation steps.

Additional information: on this system no suitable UTF-8
locales were discovered.  This most likely requires resolving
by reconfiguring the locale system.

[marsam]

I think nox is a bit unmaintained, you can try nix-review

nix-shell -p nix-review --run "nix-review pr 52524"

beware that is a huge amount of rebuilds

[stephengroat]

@marsam thanks for the help, but with this script, i'm still having an error

# git clone https://github.com/stephengroat/nixpkgs -b patch-2 && cd nixpkgs
# nix-shell -p nix-review --run "nix-review pr 52524"
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/52524/head:refs/nix-review/1
remote: Enumerating objects: 58, done.
remote: Counting objects: 100% (58/58), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 92 (delta 54), reused 56 (delta 54), pack-reused 34
Unpacking objects: 100% (92/92), done.
From https://github.com/NixOS/nixpkgs
 * [new branch]              master               -> refs/nix-review/0
 * [new ref]                 refs/pull/52524/head -> refs/nix-review/1
 * [new tag]                 18.09-beta           -> 18.09-beta
$ git worktree add ./.review/pr-52524 c5ef5c9137deeded568fd8ca1bf6754a59abc437
Preparing worktree (detached HEAD c5ef5c9137d)
Checking out files: 100% (17870/17870), done.
HEAD is now at c5ef5c9137d python.pkgs.cherrypy: disable on python2
$ git merge --no-commit 72d3636960f6b9bb0b7b360af236e4beaffd9310
Automatic merge went well; stopped before committing as requested
error: CherryPy-18.0.1 not supported for interpreter python2.7
(use '--show-trace' to show detailed location information)
https://github.com/NixOS/nixpkgs/pull/52524 failed to build
$ git worktree prune

[stephengroat]

@GrahamcOfBorg build freetype

[Mic92]

@stephengroat what locale do you have configured? Something like export LC_ALL=en_US.utf-8 should fix the nox-review failure.

[stephengroat]

@Mic92 for the newer version, i'm getting a CherryPie related error

# nix-shell -p nix-review --run "nix-review pr 52524"
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/52524/head:refs/nix-review/1
remote: Enumerating objects: 136, done.
remote: Counting objects: 100% (136/136), done.
remote: Compressing objects: 100% (35/35), done.
remote: Total 137 (delta 97), reused 130 (delta 94), pack-reused 1
Receiving objects: 100% (137/137), 271.39 KiB | 15.08 MiB/s, done.
Resolving deltas: 100% (97/97), completed with 33 local objects.
From https://github.com/NixOS/nixpkgs
 * [new branch]              master               -> refs/nix-review/0
 * [new ref]                 refs/pull/52524/head -> refs/nix-review/1
 * [new tag]                 18.09-beta           -> 18.09-beta
$ git worktree add ./.review/pr-52524 984c8431816fbb691709145806e553e7fd61b9c6
Preparing worktree (detached HEAD 984c8431816)
Checking out files: 100% (17895/17895), done.
HEAD is now at 984c8431816 Merge pull request #52895 from ivan/qbittorrent-4.1.5
$ git merge --no-commit 72d3636960f6b9bb0b7b360af236e4beaffd9310
Automatic merge went well; stopped before committing as requested
error: CherryPy-18.0.1 not supported for interpreter python2.7
(use '--show-trace' to show detailed location information)
https://github.com/NixOS/nixpkgs/pull/52524 failed to build
$ git worktree prune

[ttuegel]

This looks good to me, except that it needs to go into staging instead of master.

[stephengroat]

@ttuegel done

[ttuegel]

Thanks!

[dtzWill]

Breaks texlive?

@GrahamcOfBorg build texlive.bin.core

EDIT: and php? :( :(

EDIT2: b179338

I suggest something like the above commit--restoring the postInstall and adding --enable-freetype-config to configureFlags. Or revert entirely until this PR fixes the fallout.

[fpletz]

@dtzWill Your commit looks good to me. Cherry-picked onto staging as cabe7d6.