Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildbot: 1.4.0 -> 1.8.1 #52536

Merged
merged 2 commits into from Feb 6, 2019
Merged

buildbot: 1.4.0 -> 1.8.1 #52536

merged 2 commits into from Feb 6, 2019

Conversation

@lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Dec 19, 2018

Motivation for this change

Update all of buildbot to 1.8.0 (the master package had previously been updated to 1.5.0), and make it build again.

Things done

I also disabled buildbot's tests due to some failures. These failures were not caused by the upgrade to 1.7.0, but already occurred with 1.4.0. They are likely due to an upgrade of a dependency. I tried to bisect, but buildbot was previously broken because some of its dependencies failed to build, so I could not figure out when the tests started to fail.

I ran the NixOS tests and they passed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

@FRidh FRidh commented Dec 20, 2018

@lopsided98 lopsided98 changed the title buildbot: 1.4.0 -> 1.6.0 buildbot: 1.4.0 -> 1.7.0 Jan 5, 2019
@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Jan 5, 2019

1.7.0 has been released, so this PR now updates buildbot to this version.

@lopsided98 lopsided98 changed the title buildbot: 1.4.0 -> 1.7.0 buildbot: 1.4.0 -> 1.8.0 Feb 2, 2019
@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Feb 2, 2019

1.8.0 has been released, so this PR now updates buildbot to this version.

A change to SQLite broke sqlalchemy-migrate, which was causing the tests to fail. This PR includes an update of sqlalchemy-migrate to 0.12.0 which fixes the issue. Therefore buildbot's tests have been re-enabled.

@veprbl

This comment has been hidden.

@veprbl
Copy link
Member

@veprbl veprbl commented Feb 4, 2019

@lopsided98
Copy link
Contributor Author

@lopsided98 lopsided98 commented Feb 4, 2019

I updated to 1.8.1. I don't have time to do the update to 2.0.0 update right now since it requires changes to the tests and possibly the NixOS module (because it drops support for Python 2).

Maybe this PR should just be merged and then I'll create a new one for the update to 2.0.0?

@lopsided98 lopsided98 changed the title buildbot: 1.4.0 -> 1.8.0 buildbot: 1.4.0 -> 1.8.1 Feb 4, 2019
@veprbl
Copy link
Member

@veprbl veprbl commented Feb 4, 2019

@lopsided98 Yes, I had the same idea.

@GrahamcOfBorg build python2Packages.buildbot python2Packages.buildbot-full
@GrahamcOfBorg build python3Packages.buildbot python3Packages.buildbot-full
@GrahamcOfBorg test buildbot

veprbl
veprbl approved these changes Feb 6, 2019
Copy link
Member

@veprbl veprbl left a comment

Thank you!

@veprbl veprbl merged commit 71d66c5 into NixOS:master Feb 6, 2019
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants