New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd: migrate to using buildGoPackage #52563

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@vdemeester
Copy link
Contributor

vdemeester commented Dec 20, 2018

Motivation for this change

Part of #52469, make the runc derivation using buildGoPackage 👼

… and add man pages, which means containerd becomes a multi-output
derivation : containerd.bin and containerd.man.

cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

manName="$(basename "$manFile")" # "docker-build.1"
number="$(echo $manName | rev | cut -d'.' -f1 | rev)"
mkdir -p "$manRoot/man$number"
gzip -c "$manFile" > "$manRoot/man$number/$manName.gz"

This comment has been minimized.

@Mic92

Mic92 Dec 20, 2018

Contributor

I think we automatically compress manpages.

This comment has been minimized.

@vdemeester

vdemeester Dec 20, 2018

Contributor

oh 🤔 then there is some other packages that should change too

@vdemeester

This comment has been minimized.

Copy link
Contributor

vdemeester commented Dec 20, 2018

oh this broke the docker derivation 😅 I'll fix 👼

@vdemeester vdemeester force-pushed the vdemeester:52469-containerd-to-buildgopackage branch Dec 20, 2018

containerd: migrate to using buildGoPackage
… and add man pages, which means `containerd` becomes a multi-output
derivation : `containerd.bin` and `containerd.man`.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>

@vdemeester vdemeester force-pushed the vdemeester:52469-containerd-to-buildgopackage branch to 17ddccc Dec 20, 2018

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 21, 2018

@GrahamcOfBorg test docker

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 21, 2018

@GrahamcOfBorg build nixosTests.docker

@Mic92 Mic92 merged commit 15ec5d0 into NixOS:master Jan 11, 2019

9 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@vdemeester vdemeester deleted the vdemeester:52469-containerd-to-buildgopackage branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment