Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift: migrate to using buildGoPackage #52572

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@vdemeester
Copy link
Contributor

commented Dec 20, 2018

Motivation for this change

Part of #52469, make the runc derivation using buildGoPackage 馃懠

This means openshift becomes a multi-output derivation :
openshift.bin and openshift. (I'm not entirely sure on that one 馃槄 )

cc @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Show resolved Hide resolved pkgs/applications/networking/cluster/openshift/default.nix Outdated
Show resolved Hide resolved pkgs/applications/networking/cluster/openshift/default.nix Outdated
openshift: migrate to using buildGoPackage
This means `openshift` becomes a multi-output derivation :
`openshift.bin` and `openshift`

Signed-off-by: Vincent Demeester <vincent@sbr.pm>

@vdemeester vdemeester force-pushed the vdemeester:52469-openshift-to-buildgopackage branch to e4bc05f Dec 20, 2018

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2018

@GrahamcOfBorg build openshift

@Mic92 Mic92 merged commit 566cc6b into NixOS:master Jan 11, 2019

11 of 12 checks passed

nix-build -A openshift --argstr system x86_64-darwin Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A openshift --argstr system aarch64-linux Build Results
Details
nix-build -A openshift --argstr system x86_64-linux Build Results
Details

@vdemeester vdemeester deleted the vdemeester:52469-openshift-to-buildgopackage branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.