Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terra: 2016-06-09 -> 1.0.0-beta1 #52624

Merged
merged 1 commit into from Mar 1, 2019
Merged

terra: 2016-06-09 -> 1.0.0-beta1 #52624

merged 1 commit into from Mar 1, 2019

Conversation

@alesguzik
Copy link
Contributor

@alesguzik alesguzik commented Dec 21, 2018

Motivation for this change

Terra 1.0.0-beta1 has been released

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

@ryantm ryantm commented Feb 24, 2019

@alesguzik If upstream has a differentiation between stable and unstable releases, we try to provide the stable version in nixpkgs. It looks like this is an unstable version, so it shouldn't be packaged as the main version. If it is necessary to provide this version as a dependency, I think it should be under a different top-level attrpath name like terra_1.0.0-beta1.

I'm going to close this as is, but feel free to disagree here, and anyone should feel free to reopen if they disagree.

@ryantm ryantm closed this Feb 24, 2019
@alesguzik
Copy link
Contributor Author

@alesguzik alesguzik commented Feb 25, 2019

@ryantm this is the closest thing there is to the "release" version. 2016-06-09 that nixpkgs currently has is not a release version: tagged versions are
image

Those tags correspond to the changelog entries.

@ryantm
Copy link
Member

@ryantm ryantm commented Feb 25, 2019

Looking at that is what gives me the impression they are migrating from a stable release cycle using the date of the release, to a numbered versioning system where 1.0.0-beta is an unstable preview release of the stable 1.0.0 release. Basically the "beta" in the name looks a lot more unstable than a date in the name.

I'm really just basing it off those release names though. If you know more about how the project is run and want to reopen this, I'll defer to you.

@alesguzik
Copy link
Contributor Author

@alesguzik alesguzik commented Feb 27, 2019

@ryantm they do plan to migrate to it as soon as it will be stable. Date releases are not "stable", it's that the project has been in alpha all this time, and those were just some arbitrary reference points. And the version that we have in nixpkgs is not even one of those reference points. And it is not known when the 1.0.0 will be released. Basically without this PR we are leaving nixpkgs with an arbitrary alpha version that is 2.5 years old. I understand that after 1.0.0 release it will make sense to have only semver stable releases in nixpkgs, but until 1.0.0 is out, I think it is most reasonable to use this one.

@ryantm ryantm reopened this Feb 28, 2019
@ryantm
Copy link
Member

@ryantm ryantm commented Feb 28, 2019

@GrahamcOfBorg build terra

@ryantm
Copy link
Member

@ryantm ryantm commented Mar 1, 2019

Thanks, looks good!

@ryantm ryantm merged commit 6e5caa3 into NixOS:master Mar 1, 2019
13 checks passed
13 checks passed
terra on aarch64-linux No attempt
Details
terra on x86_64-darwin No attempt
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
terra on x86_64-linux Success
Details
@alesguzik
Copy link
Contributor Author

@alesguzik alesguzik commented Mar 4, 2019

@ryantm thanks!

@alesguzik alesguzik deleted the alesguzik:update-terra branch Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.