New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert firmware-linux-nonfree to fix broken Ath10k/QCA9377 wlan adapters [18.09] #52645

Open
wants to merge 2 commits into
base: release-18.09
from

Conversation

Projects
None yet
6 participants
@tokudan
Copy link
Contributor

tokudan commented Dec 21, 2018

Motivation for this change

Fixes #52644

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

tokudan added some commits Dec 21, 2018

@tokudan tokudan changed the title Firmware fix Revert firmware-linux-nonfree to fix broken Ath10k/QCA9377 wlan adapters Dec 21, 2018

@tokudan tokudan changed the title Revert firmware-linux-nonfree to fix broken Ath10k/QCA9377 wlan adapters Revert firmware-linux-nonfree to fix broken Ath10k/QCA9377 wlan adapters [18.09] Dec 21, 2018

@nixos-discourse

This comment has been minimized.

Copy link

nixos-discourse commented Dec 26, 2018

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/6

@badi

This comment has been minimized.

Copy link
Contributor

badi commented Dec 27, 2018

I think this would reintroduce #52430.

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Dec 27, 2018

Is there a way to only downgrade your firmware, but keep the other updates?

@osmano807

This comment has been minimized.

Copy link
Contributor

osmano807 commented Dec 28, 2018

Is there a way to only downgrade your firmware, but keep the other updates?

For my QCA9377, I just created a new package derivation like this with the latest firmware-5.bin. Hacky, but works.

@tokudan

This comment has been minimized.

Copy link
Contributor

tokudan commented Jan 4, 2019

Is there a way to only downgrade your firmware, but keep the other updates?

I can work around this by keeping a local copy of nixpkgs. But I don't know enough about firmware loading on linux to figure out how to fix this.
Currently a stable version of NixOS broke hardware compatibility, so the responsible commits should be reverted.
If that reintroduces an issue (apparently with amdgpu?) then we need to figure out another solution for that one. From what I've read on #52430 that seems to have been caused by a kernel update, which probably should be reverted, so we can get back to a version that has no software in a completely broken status.

Then we can go about actually fixing the issues as the current state basically means that stable is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment