Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pythonPackages.tensorboardX #52939

Merged
merged 3 commits into from Jun 30, 2020
Merged

added pythonPackages.tensorboardX #52939

merged 3 commits into from Jun 30, 2020

Conversation

@akamaus
Copy link
Contributor

akamaus commented Dec 26, 2018

Motivation for this change

Added an expression for tensorboardX, a standalone library for logging data for subsequent visualization by tensorboard.

Things done

Copy link
Member

FRidh left a comment

Please use the full PR template, it's there for a reason.

@akamaus akamaus force-pushed the akamaus:tensorboardX branch from 7daa7a1 to a26788e Jan 4, 2019
@akamaus
Copy link
Contributor Author

akamaus commented Jan 4, 2019

@FRidh all done

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@FRidh
Copy link
Member

FRidh commented Jan 4, 2019

@GrahamcOfBorg build python3.pkgs.tensorboardX

@akamaus akamaus force-pushed the akamaus:tensorboardX branch from a26788e to 9c91f59 Jan 7, 2019
@akamaus
Copy link
Contributor Author

akamaus commented Jan 7, 2019

@FRidh renamed to lowercase.

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

Are there any updates on this pull request, please?

@FRidh
Copy link
Member

FRidh commented Aug 13, 2019

Copy link
Member

FRidh left a comment

Looks ok

@akamaus akamaus force-pushed the akamaus:tensorboardX branch from 9c91f59 to 6a57165 Aug 20, 2019
@akamaus akamaus force-pushed the akamaus:tensorboardX branch 8 times, most recently from 9488c0a to 53c410f Aug 20, 2019
@akamaus
Copy link
Contributor Author

akamaus commented Aug 23, 2019

@FRidh, please have a look.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.
@stale stale bot added the 2.status: stale label Jun 1, 2020
@akamaus akamaus force-pushed the akamaus:tensorboardX branch from 53c410f to 9375a35 Jun 24, 2020
@akamaus akamaus requested a review from jonringer as a code owner Jun 24, 2020
@stale stale bot removed the 2.status: stale label Jun 24, 2020
@akamaus akamaus requested a review from FRidh Jun 24, 2020
@akamaus
Copy link
Contributor Author

akamaus commented Jun 24, 2020

Updated PR to latest tensorboardX-2.0, apparently, previosly failed tests were fixed upstream, so now they all pass (besides two, one for Visdom integration which is missing from nixpkgs and one trying download something with wget. All builds and works nicely for me.

Copy link
Contributor

jonringer left a comment

I think it also makes sense to squash all of the tensorboard commits, and have just a single python3Packages.tensorboardx: init at 2.0.

From the perspective master branch, the meaningful change is that a package was added, the intermediate bumps are not very consequential (at least to me).

maintainers/maintainer-list.nix Show resolved Hide resolved
@Mic92
Copy link
Contributor

Mic92 commented Jun 24, 2020

I think @mweinelt has an interest in getting this merged.

@akamaus akamaus force-pushed the akamaus:tensorboardX branch from 9375a35 to 863e28d Jun 26, 2020
@akamaus
Copy link
Contributor Author

akamaus commented Jun 26, 2020

@Mic92 commits squashed, githubId added.

Copy link
Member

mweinelt left a comment

That's a great start, I only added some style remarks.

@@ -0,0 +1,30 @@
{boto3, buildPythonPackage, crc32c, fetchFromGitHub, lib, matplotlib, moto, numpy, pillow, pytorch, protobuf, six, pytest, tensorflow-tensorboard, torchvision }:

This comment has been minimized.

Copy link
@mweinelt

mweinelt Jun 26, 2020

Member

Can you wrap this line? It is quite a bit too long to properly read on GitHub.


meta = {
description = "Library for writing tensorboard-compatible logs";
homepage = https://github.com/lanpa/tensorboard-pytorch;

This comment has been minimized.

Copy link
@mweinelt
substituteInPlace tests/test_onnx_graph.py --replace test_onnx_graph _skip_test_onnx_graph
'';

meta = {

This comment has been minimized.

Copy link
@mweinelt

mweinelt Jun 26, 2020

Member
Suggested change
meta = {
meta = with lib; {

And then cut off lib. on license, maintainers and platforms.

postPatch=''
substituteInPlace tests/test_visdom.py --replace test_TorchVis _skip_test_TorchVis
substituteInPlace tests/test_onnx_graph.py --replace test_onnx_graph _skip_test_onnx_graph
'';

This comment has been minimized.

Copy link
@mweinelt

mweinelt Jun 26, 2020

Member

The indentation here seems off.

@akamaus akamaus force-pushed the akamaus:tensorboardX branch from 863e28d to 9c86c74 Jun 28, 2020
@akamaus
Copy link
Contributor Author

akamaus commented Jun 28, 2020

@mweinelt, thanks for tips for fixing style. All done.

@Mic92
Copy link
Contributor

Mic92 commented Jun 30, 2020

@GrahamcOfBorg build python3.pkgs.tensorboardX

@Mic92
Copy link
Contributor

Mic92 commented Jun 30, 2020

@GrahamcOfBorg build python3.pkgs.tensorboardx

@Mic92 Mic92 merged commit 74cb17f into NixOS:master Jun 30, 2020
4 of 7 checks passed
4 of 7 checks passed
python3.pkgs.tensorboardx on x86_64-darwin
Details
python3.pkgs.tensorboardx on x86_64-linux
Details
grahamcofborg-eval Checking new out paths
Details
python3.pkgs.tensorboardX on aarch64-linux No attempt
Details
python3.pkgs.tensorboardX on x86_64-darwin No attempt
Details
python3.pkgs.tensorboardX on x86_64-linux No attempt
Details
python3.pkgs.tensorboardx on aarch64-linux Failure
Details
@akamaus akamaus deleted the akamaus:tensorboardX branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.