Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx-sso: init at 0.15.1 (+ nixos service/test) #53002

Merged
merged 3 commits into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@delroth
Copy link
Contributor

commented Dec 28, 2018

Motivation for this change

nginx-sso is a simple, self-contained backend for nginx's auth_request module. It can be used to implement login/logout across a set of services on a web domain, and supports 2FA (TOTP) as well as multiple authentication backends.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth delroth requested a review from Infinisil as a code owner Dec 28, 2018

@delroth delroth force-pushed the delroth:nginx-sso branch from 0b05e36 to 8d15ee2 Dec 29, 2018

@delroth delroth changed the title nginx-sso: init at 0.12.0 (+ nixos service/test) nginx-sso: init at 0.14.0 (+ nixos service/test) Dec 29, 2018

@delroth delroth force-pushed the delroth:nginx-sso branch from 8d15ee2 to 554e9eb Jan 15, 2019

@delroth delroth force-pushed the delroth:nginx-sso branch from 554e9eb to 4f16486 Jan 24, 2019

@delroth delroth changed the title nginx-sso: init at 0.14.0 (+ nixos service/test) nginx-sso: init at 0.15.1 (+ nixos service/test) Jan 24, 2019

@delroth

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

Ping? :-)

Show resolved Hide resolved nixos/modules/services/security/nginx-sso.nix Outdated
Show resolved Hide resolved nixos/modules/services/security/nginx-sso.nix Outdated
Show resolved Hide resolved nixos/modules/services/security/nginx-sso.nix Outdated
Show resolved Hide resolved nixos/modules/services/security/nginx-sso.nix Outdated
Show resolved Hide resolved nixos/modules/services/security/nginx-sso.nix

@delroth delroth force-pushed the delroth:nginx-sso branch 2 times, most recently from 87b31b5 to b708c1c Jan 29, 2019

@delroth

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@Infinisil addressed your comments fyi (not sure if you get notifications from the "resolve" button).

delroth added some commits Dec 28, 2018

@delroth delroth force-pushed the delroth:nginx-sso branch from b708c1c to 20b1feb Jan 29, 2019

@Infinisil Infinisil merged commit 400912d into NixOS:master Jan 29, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@Infinisil

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

Ah, I missed it now, but for the future, commits that add a new nixos service usually should look like "nixos/foo: init"

@delroth

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Noted. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.