Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

betaflight-configurator: init at 10.5.1 #53013

Merged
merged 4 commits into from Jun 5, 2019

Conversation

@wucke13
Copy link
Contributor

commented Dec 28, 2018

Motivation for this change

Adding more GCS/Drone Configuration tools to the nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wucke13 wucke13 force-pushed the wucke13:betaflight-configurator-naive branch from 1b835e0 to 68469e5 Feb 6, 2019

@corngood

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2019

@ryantm @wucke13 I don't think this is WIP any more, is it?

@wucke13

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

It is, but I'm on it right now. If you agree on writing the runner script using some shell magic instead of writeShellScriptBin, than I will adjust accordingly in the next hours

@corngood

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2019

Whatever works. I was just trying to ask some questions. I have no power here. :)

@wucke13 wucke13 force-pushed the wucke13:betaflight-configurator-naive branch from 68469e5 to 4fe9cbb Apr 14, 2019

@wucke13 wucke13 changed the title betaflight-configurator: init at 10.4.0 betaflight-configurator: init at 10.5.1 Apr 14, 2019

@wucke13

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

@corngood Ready for merge. Not WIP anymore.

@wucke13 wucke13 force-pushed the wucke13:betaflight-configurator-naive branch from 4fe9cbb to da95356 Apr 18, 2019

@wucke13 wucke13 force-pushed the wucke13:betaflight-configurator-naive branch from da95356 to 3d8162a Apr 30, 2019

@nyanloutre

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Hey, any news on this PR ?

@wucke13

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

@nyanloutre I think its ready for merge

@nyanloutre
Copy link
Contributor

left a comment

I had to add this to make the export save feature work, else it would just crash when atempting to open the file explorer window

wucke13 and others added some commits Nov 7, 2018

@wucke13 wucke13 force-pushed the wucke13:betaflight-configurator-naive branch from 087541d to fd121cd May 31, 2019

@wucke13

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

@nyanloutre Thanks for the two commits too. I applied adjusted accordingly. Feel free to review the current state 😄

@nixos-discourse

This comment has been minimized.

Copy link

commented Jun 5, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/12

@matthewbauer matthewbauer merged commit 693a4ef into NixOS:master Jun 5, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.