Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k2pdfopt: 2.42 -> 2.50 #53063

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@danielfullmer
Copy link
Contributor

commented Dec 30, 2018

Motivation for this change

Update to latest version of k2pdfopt. See https://www.willus.com/k2pdfopt/k2pdfopt_version.txt for changes.

Also included in this pull request is necessary fix to the mupdf .pc file we make. The library named mupdfthird was changed to mupdf-third in mupdf 1.14. Not sure if you'd like this in another pull request, but it's a pretty trivial fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danielfullmer danielfullmer force-pushed the danielfullmer:k2pdfopt-2.50 branch from e8e97d9 to 17aa0e3 Dec 30, 2018

@danielfullmer

This comment has been minimized.

Copy link
Contributor Author

commented Dec 30, 2018

Working on fixing a tesseract linking issue that arose when I tried to rebase against a more recent nixpkgs. Will update when this PR is good to review.

@danielfullmer danielfullmer force-pushed the danielfullmer:k2pdfopt-2.50 branch from 17aa0e3 to 4e9323e Dec 30, 2018

@danielfullmer

This comment has been minimized.

Copy link
Contributor Author

commented Dec 30, 2018

OK. Linking issue is fixed and it builds and runs properly for me again.

@danielfullmer

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

Closing in favor of #55148 and #55150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.