Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fetchFromGitLab to use repository archive downloads #53073

Closed
wants to merge 1 commit into from

Conversation

justinwoo
Copy link
Member

@justinwoo justinwoo commented Dec 30, 2018

  • aligns with fetchFromGitHub's use of repository archive links

  • fixes broken archive fetching due to GitLab API issues

Avoids GitLab API issues such as
https://gitlab.com/gitlab-org/gitlab-ce/issues/38537 (see also
https://gitlab.com/gitlab-org/gitlab-ce/issues/47336#note_103430000,
https://gitlab.com/gitlab-com/support-forum/issues/4015, et al)

Motivation for this change

Derivations such as shrink-path.el from emacsMelpa will not build without addressing being unable to download archives from GitLab. The method of using the GitLab API which does not correctly handle repository names simply fails, whereas use of the normal GitLab repository archives works as intended and matches the usage of the GitHub archives.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 30, 2018
@marsam
Copy link
Contributor

marsam commented Dec 30, 2018

IIUC we use the gitlab api because it has guaranteed stability #39467.
maybe for those broken melpa packages we can override their source with https://github.com/emacsmirror/

@justinwoo justinwoo force-pushed the fix-gitlab-fetch-url branch from ca70916 to c130a94 Compare December 30, 2018 17:14
@justinwoo
Copy link
Member Author

This bug does mean that not only would I have to override melpa packages, but any and all GitLab packages where I run into issues like this one. I don't see the usefulness of using a "guaranteed stable" API where bugs are never fixed.

@Ericson2314
Copy link
Member

Is there any way we could use the mirror:// or whatever it is to try both? Git Lab is notoriously buggy, and both have been broken at times.

@justinwoo justinwoo force-pushed the fix-gitlab-fetch-url branch from 5b0a9ff to c9ea588 Compare January 21, 2019 13:22
@Mic92
Copy link
Member

Mic92 commented Jan 21, 2019

Yeah the mirror solution sound good to me.

* aligns with fetchFromGitHub's use of repository archive links

* fixes broken archive fetching due to GitLab API issues

Avoids GitLab API issues such as
<https://gitlab.com/gitlab-org/gitlab-ce/issues/38537> (see also
<https://gitlab.com/gitlab-org/gitlab-ce/issues/47336#note_103430000>,
<https://gitlab.com/gitlab-com/support-forum/issues/4015>, et al)

* fixes NixOS#48215

* Allows many emacsMelpa packages to be built (e.g. shrink-path)
@justinwoo justinwoo force-pushed the fix-gitlab-fetch-url branch from 06e4e48 to b12c3bb Compare March 12, 2019 10:35
@justinwoo
Copy link
Member Author

Sorry, I have found that I will not be working on this PR any further. Please feel free to use the commits elsewhere if there is interest in enacting some change based off of this. Thanks.

@justinwoo justinwoo closed this Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: fetch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 error with fetchFromGitLab
5 participants