-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix fetchFromGitLab to use repository archive downloads #53073
Conversation
IIUC we use the gitlab api because it has guaranteed stability #39467. |
ca70916
to
c130a94
Compare
This bug does mean that not only would I have to override melpa packages, but any and all GitLab packages where I run into issues like this one. I don't see the usefulness of using a "guaranteed stable" API where bugs are never fixed. |
c130a94
to
5b0a9ff
Compare
Is there any way we could use the |
5b0a9ff
to
c9ea588
Compare
Yeah the mirror solution sound good to me. |
c9ea588
to
655ca3c
Compare
655ca3c
to
65f6a36
Compare
65f6a36
to
06e4e48
Compare
* aligns with fetchFromGitHub's use of repository archive links * fixes broken archive fetching due to GitLab API issues Avoids GitLab API issues such as <https://gitlab.com/gitlab-org/gitlab-ce/issues/38537> (see also <https://gitlab.com/gitlab-org/gitlab-ce/issues/47336#note_103430000>, <https://gitlab.com/gitlab-com/support-forum/issues/4015>, et al) * fixes NixOS#48215 * Allows many emacsMelpa packages to be built (e.g. shrink-path)
06e4e48
to
b12c3bb
Compare
Sorry, I have found that I will not be working on this PR any further. Please feel free to use the commits elsewhere if there is interest in enacting some change based off of this. Thanks. |
aligns with fetchFromGitHub's use of repository archive links
fixes broken archive fetching due to GitLab API issues
Avoids GitLab API issues such as
https://gitlab.com/gitlab-org/gitlab-ce/issues/38537 (see also
https://gitlab.com/gitlab-org/gitlab-ce/issues/47336#note_103430000,
https://gitlab.com/gitlab-com/support-forum/issues/4015, et al)
fixes 404 error with
fetchFromGitLab
#48215Allows many emacsMelpa packages to be built (e.g. shrink-path)
Motivation for this change
Derivations such as shrink-path.el from emacsMelpa will not build without addressing being unable to download archives from GitLab. The method of using the GitLab API which does not correctly handle repository names simply fails, whereas use of the normal GitLab repository archives works as intended and matches the usage of the GitHub archives.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)