Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimUtils: apply pluginToDrv recursively #53240

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Jan 2, 2019

Motivation for this change

According to a bug report I got from @MarcWeber via email, my fix in #53112 wasn't complete. When a plugin had string dependencies, evaluation would break. To fix this, this now applies pluginToDrv recursively and adds a test covering this case.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is necessary to handle plugin dependencies which also may be
strings.
@timokau timokau merged commit e33d636 into NixOS:master Jan 3, 2019
@timokau timokau deleted the vim-drv-recursively branch January 3, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants