New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.nipype: 1.1.5 -> 1.1.7 #53254

Merged
merged 2 commits into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@worldofpeace
Copy link
Member

worldofpeace commented Jan 3, 2019

Motivation for this change

Noticed it was broken in #53224

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh

This comment has been minimized.

Copy link
Member

FRidh commented Jan 3, 2019

@GrahamcOfBorg build pythonPackages.nipype python3Packages.nipype

xvfbwrapper
] ++ stdenv.lib.optional (!isPy3k) [
configparser
futures
];

checkInputs = [ pytest mock pytestcov pytest_xdist pytest-forked codecov which glibcLocales ];
buildInputs = [

This comment has been minimized.

@FRidh

FRidh Jan 3, 2019

Member

These are typically only checkInputs

This comment has been minimized.

@worldofpeace

worldofpeace Jan 3, 2019

Member

Yeah but when tests are disabled they don't get added to buildInputs so the build fails. See https://github.com/nipy/nipype/blob/dcc013b0187bf5312db9174f8cb8932991c601cb/nipype/info.py#L136

This comment has been minimized.

@FRidh

FRidh Jan 5, 2019

Member

Here they say they want users to be able to run the tests:
nipy/nipype#2649 (comment)
So, strictly speaking, it's not a requirement to use the library. Therefore, I am of the opinion we should patch pytest* out of REQUIRES. Of course, it's only an improvement.

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jan 3, 2019

Darwin build is broken because of xvfbwrapper tests failing.
Maybe we should disable tests for darwin?

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jan 5, 2019

It's actually probably a good idea to just disable them entirely. 3f4b890

worldofpeace added some commits Jan 3, 2019

pythonPackages.nipype: 1.1.5 -> 1.1.7
Fix build by dropping a patch for an issue that is already fixed.
See: nipy/nipype#2701

Also had to disable tests.
See: nipy/nipype#2839

@worldofpeace worldofpeace force-pushed the worldofpeace:nipype/1.1.7 branch from 3f4b890 to 9257887 Jan 11, 2019

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jan 11, 2019

I think I've done the things 😄

@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 11, 2019

@GrahamcOfBorg build pythonPackages.nipype python3Packages.nipype

@dotlambda dotlambda merged commit e9b34b1 into NixOS:master Jan 11, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@dotlambda

This comment has been minimized.

Copy link
Member

dotlambda commented Jan 11, 2019

I'm sure I did not click on "Squash and merge". Also, why am I the author of e9b34b1? GitHub seems to have fucked up again :(

@worldofpeace

This comment has been minimized.

Copy link
Member

worldofpeace commented Jan 11, 2019

Yeah It would appear that it was "Squash and merge", GitHub and it's sillyness 🤣

@worldofpeace worldofpeace deleted the worldofpeace:nipype/1.1.7 branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment