Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktouch: init at 18.12.0 #53256

wants to merge 250 commits into from

ktouch: init at 18.12.0 #53256

wants to merge 250 commits into from


Copy link

@schmittlauch schmittlauch commented Jan 3, 2019

Motivation for this change

This is a WIP attempt to package the KTouch typing tutor.
A small fix for qtdeclarative was necessary to get it built (see respective commit), which causes plenty of rebuilds of dependants.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

pbogdan and others added 30 commits December 9, 2018 00:13

Similar to gnused update, hash not obtained from mirrors
(since they currently 404 for this) but nix-prefetch-url
on master gnu site.
Fixes bug in some uses of '\b' in certain locales;
same bug was introduced and fixed in gnused 4.6 -> 4.7.
Copy link

ttuegel commented Jan 12, 2019

This looks good, but it needs to go into staging instead of master.

ttuegel and others added 4 commits January 12, 2019 10:21
This package contains several CMake files used for setting up its
provided tools for use in other projects build with CMake.
While packaging *ktouch* I found out that the ${_qt5Core_install_prefix}
variable doesn't expand at all, rendering the path to the `qmlcachegen`
binary useless. As a fix, the command itself is used instead of the path
to the binary.
packaging the `ktouch` touch typing tutor. So far it builds, but then
fails at runtime due to some QML loading issues.
It turned out that some dependencies described as optional caused cmake
to fail if not present. As long as it's not clear whether those are
needed [1], they are always included into the build.

Copy link
Member Author

@ttuegel looks like I cannot change the merge target of an existing PR, so I'm going to open a new one: #53859

Copy link
Member Author

@bjornfor @FRidh You mean my commits broke the build of xorg.oclock, or why are you bringing this up here?

Copy link

@schmittlauch: I commented directly on a commit in master that didn't build. I guess the commit came from this PR, since github linked the comments...?

Copy link
Member Author

TL;DR: This PR is closed, won't be merged and the commit you commented on didn't come from here.

@bjornfor No, not really. This PR was about packaging ktouch, and I suspect that @ttuegel somehow merged commits from staging into it, as this PR was supposed to go to staging instead of master.
But I saw that to late and closed this PR in favor of another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet