ktouch: init at 18.12.0 #53256
Closed
ktouch: init at 18.12.0 #53256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://savannah.gnu.org/forum/forum.php?forum_id=9331 Mirrors didn't seem to have it, hash obtained via $ nix-prefetch-url https://ftp.gnu.org/gnu/sed/sed-4.6.tar.xz
https://savannah.gnu.org/forum/forum.php?forum_id=9332 Similar to gnused update, hash not obtained from mirrors (since they currently 404 for this) but nix-prefetch-url on master gnu site.
Fixes bug in some uses of '\b' in certain locales; same bug was introduced and fixed in gnused 4.6 -> 4.7.
|
This looks good, but it needs to go into |
freetype: 2.9 -> 2.9.1
This package contains several CMake files used for setting up its
provided tools for use in other projects build with CMake.
While packaging *ktouch* I found out that the ${_qt5Core_install_prefix}
variable doesn't expand at all, rendering the path to the `qmlcachegen`
binary useless. As a fix, the command itself is used instead of the path
to the binary.
packaging the `ktouch` touch typing tutor. So far it builds, but then fails at runtime due to some QML loading issues.
It turned out that some dependencies described as optional caused cmake to fail if not present. As long as it's not clear whether those are needed [1], they are always included into the build. [1] https://bugs.kde.org/show_bug.cgi?id=402902
schmittlauch
requested review from
Ericson2314,
FRidh,
infinisil,
matthewbauer and
nbp
as code owners
GrahamcOfBorg
added
6.topic: fetch
10 tasks
|
@schmittlauch: I commented directly on a commit in master that didn't build. I guess the commit came from this PR, since github linked the comments...? |
|
TL;DR: This PR is closed, won't be merged and the commit you commented on didn't come from here. @bjornfor No, not really. This PR was about packaging ktouch, and I suspect that @ttuegel somehow merged commits from staging into it, as this PR was supposed to go to staging instead of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a WIP attempt to package the KTouch typing tutor.
A small fix for qtdeclarative was necessary to get it built (see respective commit), which causes plenty of rebuilds of dependants.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)