Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trx: init at 2018-01-23 #53324

Merged
merged 2 commits into from
Jan 4, 2019
Merged

trx: init at 2018-01-23 #53324

merged 2 commits into from
Jan 4, 2019

Conversation

hansjoergschurr
Copy link
Contributor

Motivation for this change

This adds a package for a small tool allowing streaming of audio on local networks. Using the current tip of the git repository instead of the latest release because adaptions to newer versions of ortp were done after the release.

Further work

The produced binaries currently produce a sched_setscheduler: Operation not permitted warning since they don't have permission to enable real time scheduling. I'm not sure if this should be allowed in the package, or by the user if needed. They work just fine nevertheless.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This is usually more sound then DESTDIR. Especially when it is
backed into the binary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants