Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport vivaldi update to version 2.2.1388.37-1 from unstable #53349

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Backport vivaldi update to version 2.2.1388.37-1 from unstable #53349

merged 2 commits into from
Jan 3, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 3, 2019

Motivation for this change

Backport cherry picked from commits cb1e93b and 3e00845 (PR #53315).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

@romildo Looks perfect, testing execution in a vm now.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds locally and executes in a vm

@worldofpeace worldofpeace merged commit 50debdf into NixOS:release-18.09 Jan 3, 2019
@worldofpeace
Copy link
Contributor

Thanks @romildo

@romildo romildo deleted the upd.vivaldi branch January 3, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants