Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: fix dependencies #53352

Merged
merged 3 commits into from
Jan 4, 2019
Merged

ceph: fix dependencies #53352

merged 3 commits into from
Jan 4, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from FRidh as a code owner January 3, 2019 21:08
@Mic92 Mic92 changed the title ceph: fix dependencie ceph: fix dependencies Jan 3, 2019
@Mic92 Mic92 merged commit 4f9970f into NixOS:master Jan 4, 2019
@Mic92 Mic92 deleted the fix-ceph branch January 4, 2019 07:59
@Mic92 Mic92 mentioned this pull request Jan 4, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants