Skip to content

pythonPackages.Kajiki: fix build #53362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

pythonPackages.Kajiki: fix build #53362

wants to merge 1 commit into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 4, 2019 •
edited
Loading

Motivation for this change

The test suite broke as nose wasn't supplied as check input.

See also https://hydra.nixos.org/build/86294591

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
pythonPackages.Kajiki: fix build
577a030 
The test suite broke as `nose` wasn't supplied as check input.

See also https://hydra.nixos.org/build/86294591
@Ma27 Ma27 requested a review from FRidh as a code owner January 4, 2019 00:11
@Ma27
Copy link
Member Author

Ma27 commented Jan 4, 2019

pythonPackages.pecan is still failing as it's missing mock.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 4, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 4, 2019

fixed here: #53352

@Mic92 Mic92 closed this Jan 4, 2019
@Ma27 Ma27 deleted the fix-kajiki branch January 4, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ma27 @Mic92 @GrahamcOfBorg