New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport nodejs from #53270 #53375

Open
wants to merge 7 commits into
base: staging-18.09
from

Conversation

Projects
None yet
5 participants
@adisbladis
Copy link
Member

adisbladis commented Jan 4, 2019

Motivation for this change

Backport nodejs changes from #53270.
Had to bump libuv to get nodejs-10-x to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis adisbladis force-pushed the adisbladis:nodejs-backports branch from 53ce302 to 6e951d6 Jan 4, 2019

@GrahamcOfBorg GrahamcOfBorg requested a review from cstrahan Jan 4, 2019

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Jan 4, 2019

staging-18.09 maybe?

R. RyanTM and others added some commits Aug 24, 2018

libuv: 1.21.0 -> 1.23.0
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/libuv/versions.

(cherry picked from commit 5a95b0b)
libuv: 1.23.0 -> 1.23.1 (#47763)
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/libuv/versions

(cherry picked from commit ef93155)
libuv: 1.23.1 -> 1.23.2
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/libuv/versions

(cherry picked from commit 1699401)
http-parser: 2.8.1 -> 2.9.0
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/http-parser/versions

(cherry picked from commit 5b9ad12)
nodejs-6_x: 6.14.4 -> 6.16.0
(cherry picked from commit 39bec39)
nodejs-8_x: 8.11.4 -> 8.15.0
(cherry picked from commit bf84722)
nodejs-10_x: 10.12.0 -> 10.15.0
(cherry picked from commit 4c917c6)

@adisbladis adisbladis force-pushed the adisbladis:nodejs-backports branch from 6e951d6 to 3bd7f31 Jan 10, 2019

@adisbladis adisbladis changed the base branch from release-18.09 to staging-18.09 Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment