Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edbrowse: Fix compilation against newer libcurl #53429

Merged
merged 1 commit into from
Jan 6, 2019
Merged

edbrowse: Fix compilation against newer libcurl #53429

merged 1 commit into from
Jan 6, 2019

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Jan 5, 2019 •
edited
Loading

Motivation for this change

Fixes #53426.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 5, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build edbrowse

@endgame endgame changed the title edbrowse: 3.7.4 -> git-c32fdb0 edbrowse: Fix linking against newer libcurl Jan 6, 2019
@endgame endgame changed the title edbrowse: Fix linking against newer libcurl edbrowse: Fix compilation against newer libcurl Jan 6, 2019
@endgame endgame force-pushed the edbrowse-git branch 2 times, most recently from 4e75cf2 to e6563db Compare January 6, 2019 03:28
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build edbrowse

@endgame
Copy link
Contributor Author

endgame commented Jan 6, 2019

Weird. the sha256 that came from nix-prefetch-url is not the same as the one I see if I or ofborg actually do the build.

@worldofpeace
Copy link
Contributor

Weird. the sha256 that came from nix-prefetch-url is not the same as the one I see if I or ofborg actually do the build.

fetchpatch normalizes the patch so that hash isn't the same as what is outputted by nix-prefetch-url.

@GrahamcOfBorg build edbrowse

@worldofpeace worldofpeace merged commit 7214866 into NixOS:master Jan 6, 2019
@worldofpeace
Copy link
Contributor

Thanks for the fix @endgame

@endgame endgame deleted the edbrowse-git branch January 7, 2019 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbogdan pbogdan pbogdan left review comments

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@endgame @worldofpeace @pbogdan @GrahamcOfBorg