Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpython: Un-remove some test data #53479

Closed

Conversation

MostAwesomeDude
Copy link
Contributor

These certificates are used in asyncio's tests in a way that doesn't
affect CPython directly, but does affect some dependencies, in
particular txaio.

Fixes #53474.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

These certificates are used in asyncio's tests in a way that doesn't
affect CPython directly, but does affect some dependencies, in
particular txaio.

Fixes NixOS#53474.
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased onto staging. Also, build all interpreters twice with the second time using --check to see if the build is still reproducible. I would expect so.

@FRidh
Copy link
Member

FRidh commented Jan 6, 2019

Actually, no, all that it needs is a *pem file. I don't think we should include that. Just disable the test or provide an alternative *pem file.

@FRidh FRidh closed this Jan 6, 2019
@andrew-d
Copy link
Contributor

andrew-d commented Jan 7, 2019

@FRidh - Sorry, do you mind clarifying your proposed solution here? My understanding is that the standard library has a module called asyncio.test_utils, which relies on the .pem file existing. Code that uses the Python standard library will thus break if we don't include these files. This feels like we're doing the wrong thing here, not a problem with Python.

@FRidh
Copy link
Member

FRidh commented Jan 7, 2019

asyncio.test_utils is undocumented and not part of the public API as far as I know.

@andrew-d
Copy link
Contributor

andrew-d commented Jan 7, 2019 via email

worldofpeace added a commit that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants