-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next #53483
Merged
Merged
Staging next #53483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://savannah.gnu.org/forum/forum.php?forum_id=9331 Mirrors didn't seem to have it, hash obtained via $ nix-prefetch-url https://ftp.gnu.org/gnu/sed/sed-4.6.tar.xz
https://savannah.gnu.org/forum/forum.php?forum_id=9332 Similar to gnused update, hash not obtained from mirrors (since they currently 404 for this) but nix-prefetch-url on master gnu site.
Fixes bug in some uses of '\b' in certain locales; same bug was introduced and fixed in gnused 4.6 -> 4.7.
Fixes CVE-2018-16864 & CVE-2018-16865 (journald stack clash). Fixes #53755. Also updates the debian patches to fix CVE-2018-15686. Fixes #52250.
A couple thousand rebuilds have accumulated on master.
Do you know of any blockers? Hydra link: https://hydra.nixos.org/eval/1499909?compare=1499904 It's a bit messy due to various transient problems: on darwin it was one machine killing builds (usually during unpacking), on aarch64 big builds sometimes time out now. Still, there's some security stuff and a fix for a possibly nasty gtk3 problem, so I'd be inclined to merge to master within one day. |
Before this commit it built fine a few times for me, i.e. without the single test, but it failed on Hydra anyway. I guess jtojnar also tested the final expression with all tests, so apparently they are sensitive the the kind of machine they run on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: work-in-progress
This PR isn't done
6.topic: fetch
Fetchers (e.g. fetchgit, fetchsvn, ...)
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: python
6.topic: xfce
The Xfce Desktop Environment
8.has: clean-up
8.has: documentation
This PR adds or changes documentation
8.has: module (update)
This PR changes an existing module in `nixos/`
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 501+
10.rebuild-darwin-stdenv
This PR causes stdenv to rebuild
10.rebuild-linux: 501+
10.rebuild-linux-stdenv
This PR causes stdenv to rebuild
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)