-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix futhark build on Darwin #53523
Fix futhark build on Darwin #53523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks. The following runs successfully on my Mac Book Pro:
|
Can it compile anything on Darwin though? Just run through the first example on https://futhark-lang.org/examples.html And what was the error on Darwin? |
Works for me with the OpenCL backend. Keep in mind you need to pass arguments on stdin. |
Odd, because the wrapping thing is not present at all on Darwin now, no idea how it can still work. |
I don't know what you mean, can you elaborate? |
The line in this PR makes it such that on Darwin it uses the unwrapped Futhark package. The wrapping logic under that line will only be applied on non-Darwin. And I added that logic down there to make compiling work, because it didn't work if it wasn't wrapped properly. |
Have you tried it on Darwin? What's the error? |
Um, I thought you were on Darwin, because I asked earlier whether it worked on Darwin and you replied that it does.. |
I'm on Darwin and it does work for me, I was just asking if it was different for you. The wrapper isn't needed on Darwin. There's no ocl-icd and everything should be available through OpenCL.framework. |
Oh I see, no I'm not on darwin. @jacereda Do you have |
It's finding impure dependencies, it will run if you leave /usr/bin in the path. |
Yeah but we don't want impure dependencies in Nix. If somebody doesn't have gcc/clang installed, the program should still run. |
Motivation for this change
Futhark won't build on Darwin and there's duplication (obsolete non-hackage package).
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)