Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-xray-daemon-V3.0.0 | awx-xray-daemon: init at V3.0.0 #53565

Open
wants to merge 5 commits into
base: master
from

Conversation

@NRHelmi
Copy link

commented Jan 7, 2019

Motivation for this change

The AWS X-Ray daemon is a software application that listens for traffic on UDP port 2000, gathers raw segment data, and relays it to the AWS X-Ray API.

The pull request contains the xray daemon packaged next to its nixos service.
This should add support to aws xray daemon in nixos.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (ubuntu 16.04)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
nix path-info -rS /nix/store/gbppfb3i7xv6lp7n5ng015x09kqmldnj-aws-xray-daemon-V3.0.0-bin
/nix/store/794g4fijpi67xk9ri99f8i0hhmj49rr9-tzdata-2018g              	    2095096
/nix/store/gbppfb3i7xv6lp7n5ng015x09kqmldnj-aws-xray-daemon-V3.0.0-bin	   37261432
/nix/store/xdsjx0gba4id3yyqxv66bxnm2sqixkjj-glibc-2.27                	   25010568
/nix/store/yzfwmssgpkff21f4xcnk2m8vav6nwlah-iana-etc-20180905         	     562856
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
I think I'm missing the maintainer. Don't know who to set to ?

@NRHelmi NRHelmi requested a review from Infinisil as a code owner Jan 7, 2019

@AmineChikhaoui

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

@GrahamcOfBorg build aws-xray-daemon

@AmineChikhaoui

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

@NRHelmi indentation is 2 spaces in nix

NRHelmi added some commits Jan 7, 2019

@AmineChikhaoui

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@GrahamcOfBorg build aws-xray-daemon

@nixos-discourse

This comment has been minimized.

Copy link

commented Jan 31, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-january/2002/3

@nixos-discourse

This comment has been minimized.

Copy link

commented Apr 11, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/18

@NixOS NixOS deleted a comment from nixos-discourse Apr 11, 2019

in
{
options.services.aws-xray-daemon = {
enable = mkEnableOption "Whether to enable aws-xray-daemon service";

This comment has been minimized.

Copy link
@ryantm

ryantm Apr 11, 2019

Member
Suggested change
enable = mkEnableOption "Whether to enable aws-xray-daemon service";
enable = mkEnableOption "the aws-xray-daemon service";

The "whether to enable" part gets added automatically.


buildGoPackage rec {
name = "aws-xray-daemon-${version}";
version = "V3.0.0";

This comment has been minimized.

Copy link
@ryantm

ryantm Apr 11, 2019

Member

It's not typical to have the prefix of V in the version, even if it is in the tag or release name.

Suggested change
version = "V3.0.0";
version = "3.0.0";
src = fetchFromGitHub {
owner = "aws";
repo = "aws-xray-daemon";
rev = "${version}";

This comment has been minimized.

Copy link
@ryantm

ryantm Apr 11, 2019

Member
Suggested change
rev = "${version}";
rev = "V${version}";
{ stdenv, buildGoPackage, fetchFromGitHub }:

buildGoPackage rec {
name = "aws-xray-daemon-${version}";

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Apr 22, 2019

Member
Suggested change
name = "aws-xray-daemon-${version}";
pname = "aws-xray-daemon";

name becomes ${pname}-${version} automatically.


src = fetchFromGitHub {
owner = "aws";
repo = "aws-xray-daemon";

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Apr 22, 2019

Member
Suggested change
repo = "aws-xray-daemon";
repo = pname;
};
};
};
}

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Apr 22, 2019

Member

missing final newline

description = "aws X-RAY daemon.";
license = stdenv.lib.licenses.asl20;
};
}

This comment has been minimized.

Copy link
@worldofpeace

worldofpeace Apr 22, 2019

Member

missing final newline

@worldofpeace
Copy link
Member

left a comment

Please bump aws-xray-daemon to its latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.