Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxvt_unicode: fix build #53578

Merged
merged 1 commit into from Jan 9, 2019

Conversation

@pbogdan
Copy link
Member

commented Jan 7, 2019

Motivation for this change

Fix build following changes in #52100 and #51770

/cc @volth for the Perl changes

I don't (knowingly) use any Perl functionality of urxvt ATM so can't verify this actually works for anything provided by the Perl modules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MP2E

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

I made an identical change local to my machine and it works, so this LGTM 👍 since I don't use the perl functionality of urxvt either, I can't test that part

@pbogdan

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2019

@GrahamcOfBorg build rxvt_unicode

@7c6f434c

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Weird. I have rxvt_unicode installed from f27fe44 (2019-01-05)…

I think alt-s for scrollback search is implemented via Perl functionality, and it should be enabled by default.

@pbogdan

This comment has been minimized.

Copy link
Member Author

commented Jan 7, 2019

That's presumably from before the last staging-next merge into master? (I haven't checked, sorry..)

And I have now tested some basic Perl functionality (highlighting and matching URLs as per Arch wiki) and it appears to work.

@7c6f434c

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

(checked staging next merge) indeed. Re: Perl functionality — nice, thanks

@7c6f434c 7c6f434c merged commit 9d3c5a2 into NixOS:master Jan 9, 2019
12 checks passed
12 checks passed
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A rxvt_unicode --argstr system aarch64-linux Build Results
Details
nix-build -A rxvt_unicode --argstr system x86_64-linux Build Results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.