Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readline8,bash5: init #53628

Merged
merged 8 commits into from
Jan 17, 2019
Merged

readline8,bash5: init #53628

merged 8 commits into from
Jan 17, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 8, 2019

Motivation for this change

New bash (and readline)! \o/

This adds the new versions but
doesn't change the defaults for anything.

"yet". :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested briefly, and with x86_64 musl.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 8, 2019

Statically linked bash 5 using musl: /nix/store/9wfgiygqnzzfz6fpd5jsbr8fifawr3d3-bash-5.0-p0 which you can grab via the ALLVM cachix FWIW! See https://allvm.cachix.org for setup, then point nix-store -r or other commands at the path.

Built without explicitly disabling bash malloc, which might be a problem but thought I'd see how vanilla bash worked :). And recent musl's support for malloc interposition/replacement means there's reason for it to maybe work. Anyway, enjoy!

EDIT: bash5Interactive (with readline): /nix/store/7c9gl3601khn3mdkkb4nq77ws2rsz7jd-bash-interactive-5.0-p0/bin/bash ❤️

@Mic92
Copy link
Member

Mic92 commented Jan 8, 2019

Why not upgrading our own bash version instead?

@Ma27 Ma27 requested a review from peti January 8, 2019 12:10
@dtzWill
Copy link
Member Author

dtzWill commented Jan 8, 2019 via email

pkgs/shells/bash/5.0.nix Outdated Show resolved Hide resolved
@Mic92
Copy link
Member

Mic92 commented Jan 9, 2019

mhm for readline it already seems to be too late to switch conventions in naming. Let's not make the same mistake for bash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants