-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readline8,bash5: init #53628
readline8,bash5: init #53628
Conversation
Works for me and they've had quite some time to fix it ;).
Statically linked bash 5 using musl: Built without explicitly disabling bash malloc, which might be a problem but thought I'd see how vanilla bash worked :). And recent musl's support for malloc interposition/replacement means there's reason for it to maybe work. Anyway, enjoy! EDIT: bash5Interactive (with readline): |
Why not upgrading our own bash version instead? |
I wanted to try it without certifying it doesn't break things ;).
I imagine it's relatively safe?
Certainly not a change to be made lightly, IMO.
Behavioral differences that are subtle might break things
not immediately apparent, for example this in the announcement:
… There are a number of changes to the
expansion of $@ and $* in various contexts where word splitting is not
performed to conform to a Posix standard interpretation, and additional
changes to resolve corner cases for Posix conformance.
On Tue, 08 Jan 2019 09:10:16 +0000 (UTC), Jörg Thalheim ***@***.***> wrote:
Why not upgrading our own bash version instead?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#53628 (comment) part: text/html
|
Leave the configureFlags, esp disabling bash malloc.
73e0526
to
4d24a84
Compare
for different versions we use underscore
mhm for readline it already seems to be too late to switch conventions in naming. Let's not make the same mistake for bash. |
Motivation for this change
New bash (and readline)! \o/
This adds the new versions but
doesn't change the defaults for anything.
"yet". :)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)Tested briefly, and with x86_64 musl.