/nixpkgs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmd: 2.083.1 -> 2.084.0, dub: 1.12.1 -> 1.13.0, dtools: 2.083.1 -> 2.084.0, Literate: 2018-12-23 -> 2019-01-08 #53666

Merged
merged 4 commits into from Jan 10, 2019

Conversation

Reviewers

@veprbl veprbl

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
4 participants
@ThomasMader @veprbl @zyedidia @GrahamcOfBorg
@ThomasMader
Copy link
Contributor

ThomasMader commented Jan 8, 2019 •
edited

Motivation for this change

Version updates

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ThomasMader
dmd: 2.083.1 -> 2.084.0
Loading status checks…
92236be
@ThomasMader

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ThomasMader commented Jan 8, 2019

@GrahamcOfBorg build dmd

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 8, 2019

@veprbl veprbl added the 11.by: package-maintainer label Jan 8, 2019

@veprbl

This comment has been minimized.

Sign in to view
Copy link
Member

veprbl commented Jan 8, 2019

@GrahamcOfBorg build dmd
@veprbl

This comment has been minimized.

Sign in to view
Copy link
Member

veprbl commented Jan 8, 2019

This seems to break Literate:

dub --root=lit/tangle build
Performing "debug" build using dmd for x86_64.
tangle ~master: building configuration "application"...
lit/tangle/src/parser.d(212,14): Error: package `std.regex` is not accessible here, perhaps add `static import std.regex;`
lit/tangle/src/util.d(48,25): Deprecation: `parser.matchAll` is not visible from module `util`
lit/tangle/src/util.d(48,45): Deprecation: `parser.regex` is not visible from module `util`
lit/tangle/src/util.d(48,68): Deprecation: `parser.matchAll` is not visible from module `util`
lit/tangle/src/util.d(48,88): Deprecation: `parser.regex` is not visible from module `util`
lit/tangle/src/util.d(50,29): Deprecation: `parser.matchAll` is not visible from module `util`
lit/tangle/src/util.d(50,49): Deprecation: `parser.regex` is not visible from module `util`
dmd failed with exit code 1.
make: *** [Makefile:11: bin/tangle] Error 2
@ThomasMader

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ThomasMader commented Jan 8, 2019

@zyedidia Literate has compile errors with dmd 2.084.0 could you please fix them?

@ThomasMader ThomasMader changed the title dmd: 2.083.1 -> 2.084.0 [WIP] dmd: 2.083.1 -> 2.084.0 Jan 8, 2019

zyedidia added a commit to zyedidia/Literate that referenced this pull request Jan 8, 2019

@zyedidia
Fix dmd 2.084 compilation errors 
Ref NixOS/nixpkgs#53666
e20c5c8
@zyedidia

This comment has been minimized.

Sign in to view
Copy link

zyedidia commented Jan 8, 2019

Should be fixed now. Let me know if there are more problems.
@ThomasMader

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

ThomasMader commented Jan 9, 2019

@zyedidia Thank you for the quick fix. No problems anymore.

@veprbl I updated the Literate package and also dub and dtools as they are connected to dmd. Everything should be good now.

@GrahamcOfBorg build dub dtools Literate

@ThomasMader ThomasMader changed the title [WIP] dmd: 2.083.1 -> 2.084.0 dmd: 2.083.1 -> 2.084.0, dub: 1.12.1 -> 1.13.0, dtools: 2.083.1 -> 2.084.0, Literate: 2018-12-23 -> 2019-01-08 Jan 9, 2019

@veprbl

This comment has been minimized.

Sign in to view
Copy link
Member

veprbl commented Jan 10, 2019

@GrahamcOfBorg build dmd
@veprbl

This comment has been minimized.

Sign in to view
Copy link
Member

veprbl commented Jan 10, 2019

@GrahamcOfBorg build dub dtools Literate
@veprbl

veprbl approved these changes Jan 10, 2019
View changes

@veprbl veprbl merged commit 9fac225 into NixOS:master Jan 10, 2019
10 checks passed

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment