Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.genvalidity-hspec: don't run tests #53682

Conversation

@cdepillabout
Copy link
Member

commented Jan 9, 2019

Motivation for this change

The haskellPackages.genvalidity-hspec package compiles correctly but
the tests fail. However the package appears to work fine. I believe this is
caused by the update to GHC 8.6.

I have tested a couple packages that use this as a dependency, including focuslist and termonad. They both compile fine and their tests pass (which are using genvalidity-hspec).

Here is the upstream issue: NorfairKing/validity#55

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The `haskellPackages.genvalidity-hspec` package compiles correctly but
the tests fail.  However the package appears to work fine.  I believe this is
caused by the update to GHC 8.6.

Here is the upstream issue: NorfairKing/validity#55
@NorfairKing

This comment has been minimized.

Copy link

commented Jan 9, 2019

Hold on, this is not the right fix! This problem causes certain parts of the package to crash. It is a forward incompatibility. I'm releasing a fix today.

@cdepillabout

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

@NorfairKing Thanks for the update! I'll go ahead and close this PR then.

If you release a new version of genvalidity-hspec to Hackage, it should automatically be pulled into nixpkgs the next time the Hackage packages are updated. This generally happens once a week. So genvalidity-hspec should be able to be compiled then.

@cdepillabout cdepillabout deleted the cdepillabout:dont-run-genvalidity-hspec-tests branch Jan 9, 2019
@NorfairKing

This comment has been minimized.

Copy link

commented Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.