New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scons: 3.0.2 -> 3.0.3 #53685

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@dtzWill
Copy link
Contributor

dtzWill commented Jan 9, 2019

https://scons.org/scons-303-is-available.html

cc e1d9854

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested it built, nothing more, FWIW.

@primeos
Copy link
Member

primeos left a comment

Hey @dtzWill, thanks for your PR but please note that this is a build system and not a simple package, this means it should be tested extensively (incl. all rebuilds it causes) before changing the default. Especially scons often contains regressions (especially 3.0.0 broke 25-50% of the rebuilds, IIRC).

Also: Please include a reference to the changelog in the commit message, like in d376ffe.

And it would help if you cc me explicitly (unfortunately I do not get a notification if the commit is referenced), as I nearly missed this PR.

@@ -9040,7 +9040,7 @@ in
selendroid = callPackage ../development/tools/selenium/selendroid { };

sconsPackages = callPackage ../development/tools/build-managers/scons { };
scons = sconsPackages.scons_3_0_2;
scons = sconsPackages.scons_3_0_3;

This comment has been minimized.

@primeos

primeos Jan 9, 2019

Member

Could you please keep the current default and simply add the new version?

@primeos

This comment has been minimized.

Copy link
Member

primeos commented Jan 9, 2019

You may actually also leave this commit as it is and I will edit it accordingly after testing the rebuilds (please let me know if you do not want this).

But for the next time: Please try to focus on updating unmaintained packages as that would help way more and this actually complicates my workflow (and therefore increases my workload). But thanks for the good intentions (though "Tested it built, nothing more, FWIW." actually leaves me a bit troubled...).

@primeos
Copy link
Member

primeos left a comment

No regressions and no deprecations this time. #YAY

@primeos primeos merged commit 28c63d5 into NixOS:master Jan 10, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment