Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash,readline80: upgrade bash 4 -> 5, init readline80 #53687

Open
wants to merge 1 commit into
base: staging
from

Conversation

@dtzWill
Copy link
Contributor

dtzWill commented Jan 9, 2019

Motivation for this change

Essentially same as #53628 only rebased to staging
and instead of (temporary?) top-level variants
go ahead and make it the default.

Naturally needs to be tested carefully first!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Jan 9, 2019

This makes it the default, per your suggestion @Mic92 :).

Also looks like my concerns about breakage were warranted, our stdenv's consumeEntire seems not to work with this:

consumeEntire(): ERROR: Input null bytes, won't process

cc stdenv maintainers: @Ericson2314 @matthewbauer

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Jan 9, 2019

You might want to cherry-pick: 26c7c59

@Mic92

This comment has been minimized.

Copy link
Contributor

Mic92 commented Jan 17, 2019

Now this one can be rebased.

@dtzWill dtzWill force-pushed the dtzWill:experimental/bash5-default branch from ee5071c to 8e98a33 Jan 20, 2019

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Jan 20, 2019

See also #54353 FWIW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.