Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concourse #53691

Open
wants to merge 33 commits into
base: master
from

Conversation

@dingxiangfei2009
Copy link
Contributor

commented Jan 9, 2019

Motivation for this change

In this pull request, we provide Nix expression for evaluating concourse and fly, as well as systemd service units for setting up concourse ATC and/or worker.

Concourse: https://concourse-ci.org

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dingxiangfei2009

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

@GrahamcOfBorg build concourse

@dingxiangfei2009

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

@Infinisil I have question about CI. It appears that CI refused to evaluate a derivation because the derivator was not in the store. How can I fix this problem?

@Infinisil

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

Not sure what the problem is. In any case you should clean up the commits in this PR. This means:

  • One commit for adding yourself as a maintainer
  • A single commit for every package added
  • A single commit for every NixOS module added
  • Get rid of all merges, you should always rebase instead
  • Format your commit message according to the Contribution Guidelines, also linked to from the PR template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.