Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] rambox: update electron to 3.x #53692

Merged
merged 3 commits into from Jan 9, 2019

Conversation

@Mic92
Copy link
Contributor

commented Jan 9, 2019

Motivation for this change

security security.
@mrVanDalo for testing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92 added 2 commits Jan 9, 2019
electron_3: init at 3.1.0
electron 4 had many breaking changes in their API,
breaking rambox. Since the 3.x version is still maintained,
we can add an older variant.

(cherry picked from commit 66c1f82)
rambox: downgrade electron to 3.x
(cherry picked from commit fdb87a0)
@mrVanDalo

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

looks good to me. I tested it via nix-review

electron_3: also update arm hashes
(cherry picked from commit 60703db)
@Mic92

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

@GrahamcOfBorg build rambox

@Mic92 Mic92 merged commit 23b9f34 into NixOS:release-18.09 Jan 9, 2019

11 of 14 checks passed

nix-build -A electron_3 -A rambox --argstr system aarch64-linux Build Results
Details
nix-build -A rambox --argstr system aarch64-linux Build Results
Details
nix-build -A rambox --argstr system x86_64-linux Build Results
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A electron_3 -A rambox --argstr system x86_64-linux Build Results
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.