Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsForQt5.qgpgme: fix tests after 2019-01-06 #53693

Merged
merged 1 commit into from Jan 9, 2019

Conversation

@hedning
Copy link
Contributor

commented Jan 9, 2019

The keys used in one of the qt tests expired on 2019-01-06 breaking the build.

closes #53632

Edit: upstream issue: https://dev.gnupg.org/T3815#121469

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

libsForQt5.qgpgme: fix tests after 2019-01-06
The keys used in one of the qt tests expired on 2019-01-06 breaking the build.

closes #53632
@bkchr
bkchr approved these changes Jan 9, 2019

@hedning hedning merged commit 5cbb010 into NixOS:master Jan 9, 2019

12 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A libsForQt5.qgpgme --argstr system aarch64-linux Build Results
Details
nix-build -A libsForQt5.qgpgme --argstr system x86_64-linux Build Results
Details

@hedning hedning deleted the hedning:fix-qgpgme branch Jan 9, 2019

patches = [
(fetchpatch {
name = "fix-key-expiry.patch";
url = "https://files.gnupg.net/file/data/fehgbjmataj5tc2pnfhj/PHID-FILE-aqck6l4elhw53tjanrie/file";

This comment has been minimized.

Copy link
@volth

volth Jan 22, 2019

Contributor

404 Not Found as by now

This comment has been minimized.

Copy link
@hedning

This comment has been minimized.

Copy link
@volth

volth Jan 22, 2019

Contributor

or "https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=patch;h=66376f3e206a1aa791d712fb8577bb3490268f60" (hash different because less number of unaffected lines are included in the patch)

This comment has been minimized.

Copy link
@primeos

primeos Jan 24, 2019

Member

Am I missing a reason why no one actually changed this (it would e.g. cause a few rebuilds but IMO it would definitely make sense, not sure if everyone uses https://hydra.nixos.org)? If not I would suggest we use the URL from @volth (as the patch is more compact and this commit is from the master branch). If no one changes this and/or responds I'll change it in a couple of hours (before we forget about it and it causes some issues (cache misses, etc.)).

This comment has been minimized.

Copy link
@volth

volth Jan 24, 2019

Contributor

Am I missing a reason why no one actually changed this

I assume neither @hedning nor me have write access and it seemed to small an issue to make a PR, so it was just left for a passing-by nixos member :)

This comment has been minimized.

Copy link
@primeos

primeos Jan 24, 2019

Member

Ok, thanks for the quick response, I've updated the URL in 399761e.

primeos added a commit that referenced this pull request Jan 24, 2019
gpgme: Update the URL for fix-key-expiry.patch
The old URL was gone, see:
#53693 (review)

Thanks @volth :)
coreyoconnor added a commit to coreyoconnor/nixpkgs that referenced this pull request Jan 25, 2019
danbst added a commit to danbst/nixpkgs that referenced this pull request Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.