Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Adds patch for fixing wifi on raspberry pi #53694

Merged
merged 1 commit into from Jan 9, 2019

Conversation

@bkchr
Copy link
Contributor

commented Jan 9, 2019

Motivation for this change

Fixes wifi on raspberry pi on latest kernel.

Ping: @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.


raspberry_pi_wifi_fix = rec {
name = "raspberry-pi-wifi-fix";
patch = ./raspberry-pi-wifi-fix.patch;

This comment has been minimized.

Copy link
@Mic92

Mic92 Jan 9, 2019

Contributor

Can you pull from here? I don't see the patch in master so I assume it is still in some other branch:

https://raw.githubusercontent.com/archlinuxarm/PKGBUILDs/730522ae76aa57b89fa317c5084613d3d50cf3b8/core/linux-aarch64/0005-mmc-sdhci-iproc-handle-mmc_of_parse-errors-during-pr.patch

It was acked by a kernel maintainer so.

@bkchr bkchr force-pushed the bkchr:raspberry_wifi_fix branch from 609e4bf to a90fc6d Jan 9, 2019

@bkchr

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

@Mic92 updated :)

@Mic92 Mic92 merged commit 9e4fe77 into NixOS:master Jan 9, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@kwohlfahrt

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

Could this be backported to linux_4_19 on stable (18.09)? I think I am seeing the same issue there - the wifi chip is not visible even though the brcmfmac module loads without issues.

This is a recent regression, 4.19.9 is OK, 4.19.13 is not.

@Mic92 Mic92 referenced this pull request Jan 10, 2019
1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.