Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exfat-nofuse: unbreak for 4.18 and 4.20 #53696

Merged
merged 1 commit into from Jan 9, 2019

Conversation

@makefu
Copy link
Contributor

commented Jan 9, 2019

Motivation for this change

fix exfat-nofuse for linuxPackages_latest

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@makefu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

@GrahamcOfBorg build linuxPackages.exfat-nofuse linuxPackages_latest-libre.exfat-nofuse

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

review is still running. This is one message I got:

builder for '/nix/store/6v0lpnglxwgjj2dwzbaz3z0d9dcv2wy2-exfat-nofuse-2018-04-16-5.0-rc1.drv' failed with exit code 2; last 10 log lines:
    else if ((opts->errors == EXFAT_ERRORS_RO) && !(sb->s_flags & MS_RDONLY)) {
                                                                  ^~~~~~~~~
                                                                  IS_RDONLY
  /build/source/exfat_core.c:1760:64: note: each undeclared identifier is reported only once for each function it appears in
  make[4]: *** [/nix/store/lfqxiwrk16kf2c2qz02wf6964hbzkgah-linux-5.0-rc1-dev/lib/modules/5.0.0-rc1/source/scripts/Makefile.build:277: /build/source/exfat_core.o] Error 1
  make[3]: *** [/nix/store/lfqxiwrk16kf2c2qz02wf6964hbzkgah-linux-5.0-rc1-dev/lib/modules/5.0.0-rc1/source/Makefile:1553: _module_/build/source] Error 2
  make[2]: *** [Makefile:152: sub-make] Error 2
  make[1]: *** [Makefile:15: __sub-make] Error 2
  make[1]: Leaving directory '/nix/store/lfqxiwrk16kf2c2qz02wf6964hbzkgah-linux-5.0-rc1-dev/lib/modules/5.0.0-rc1/build'
  make: *** [Makefile:35: all] Error 2
builder for '/nix/store/940nj3rrm79dwvpmmh9ds5bw86dccbmq-exfat-nofuse-2018-04-16-4.18.2018.10.12.drv' failed with exit code 2; last 10 log lines:
  /build/source/exfat_super.c:178:6: note: expected 'struct timespec *' but argument is of type 'struct timespec64 *'
   void exfat_time_unix2fat(struct exfat_sb_info *sbi, struct timespec *ts,
        ^~~~~~~~~~~~~~~~~~~
  cc1: some warnings being treated as errors
  make[4]: *** [/nix/store/vc1q3hvnv4mgwyvfpnb93br6x17svz81-linux-4.18.2018.10.12-dev/lib/modules/4.18.0/source/scripts/Makefile.build:318: /build/source/exfat_super.o] Error 1
  make[3]: *** [/nix/store/vc1q3hvnv4mgwyvfpnb93br6x17svz81-linux-4.18.2018.10.12-dev/lib/modules/4.18.0/source/Makefile:1500: _module_/build/source] Error 2
  make[2]: *** [Makefile:146: sub-make] Error 2
  make[1]: *** [Makefile:24: __sub-make] Error 2
  make[1]: Leaving directory '/nix/store/vc1q3hvnv4mgwyvfpnb93br6x17svz81-linux-4.18.2018.10.12-dev/lib/modules/4.18.0/build'
  make: *** [Makefile:35: all] Error 2
@Mic92

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Only the following fails:

linuxPackages-libre.exfat-nofuse linuxPackages_testing_bcachefs.exfat-nofuse linuxPackages_testing_hardened.exfat-nofuse

looks good to me!

@Mic92 Mic92 merged commit e6ca0fb into NixOS:master Jan 9, 2019

12 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
nix-build -A linuxPackages.exfat-nofuse -A linuxPackages_latest-libre.exfat-nofuse --argstr system aarch64-linux Build Results
Details
nix-build -A linuxPackages.exfat-nofuse -A linuxPackages_latest-libre.exfat-nofuse --argstr system x86_64-linux Build Results
Details
@makefu

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

@GrahamcOfBorg build linuxPackages-libre.exfat-nofuse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.